Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 missing ChromeOS platform #286

Closed
ffaubert opened this issue Jan 23, 2019 · 3 comments
Closed

v2 missing ChromeOS platform #286

ffaubert opened this issue Jan 23, 2019 · 3 comments

Comments

@ffaubert
Copy link
Contributor

I'm in the process of migrating my application from v1.9.4 to v2 and noticed that ChromeOS is no longer detectable as a built in operating system. I can work around it by using the test(/CrOS/) (which matches how v1.9.4 worked), but it this was built in like the other operating systems.
@lancedikson
Copy link
Collaborator

Hi, @ffaubert. Right, I can see that there's no a proper detection specification for CrOS in bowser. We could make a hot-fix for that. Do you feel like making a PR with such a functionality? It should be a piece cake putting a spec object to parser-os.js and fixing a couple of integration tests that will fail with a new spec :)

@ffaubert
Copy link
Contributor Author

@lancedikson Sure thing. I submitted PR #287 for that. I also submitted PR #288 which makes the code in my app a bit cleaner.

@lancedikson
Copy link
Collaborator

Thanks, @ffaubert for your PRs. I've released them as 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lancedikson @ffaubert