Fix: Get mode button from header element rather than container (#308)

- This is a fix specifically for Annotations in the ContentPreview element or other cases when the header element is not contained inside box-content-preview
box · Dec 4, 2018 · b50d72b · b50d72b
1 parent 734fc6c
commit b50d72b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/controllers/AnnotationModeController.js b/src/controllers/AnnotationModeController.js
@@ -151,7 +151,7 @@ class AnnotationModeController extends EventEmitter {
      */
     getButton(annotatorSelector: string): HTMLElement {
         // $FlowFixMe
-        return this.container.querySelector(annotatorSelector);
+        return this.headerElement.querySelector(annotatorSelector);
     }
 
     /**

diff --git a/src/controllers/__tests__/AnnotationModeController-test.js b/src/controllers/__tests__/AnnotationModeController-test.js
@@ -123,15 +123,11 @@ describe('controllers/AnnotationModeController', () => {
             it('should return the annotation mode button', () => {
                 const buttonEl = document.createElement('button');
                 buttonEl.classList.add('class');
-                controller.container = document.createElement('div');
-                controller.container.appendChild(buttonEl);
+                controller.headerElement = document.createElement('div');
+                controller.headerElement.appendChild(buttonEl);
 
                 expect(controller.getButton('.class')).not.toBeNull();
             });
-
-            it('should return null if no headerElement', () => {
-                expect(controller.getButton('.class')).toBeNull();
-            });
         });
 
         describe('showButton()', () => {