Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archive): Add sortable columns to ArchiveExplorer #1126

Merged
merged 6 commits into from
Dec 19, 2019

Conversation

mickr
Copy link
Contributor

@mickr mickr commented Dec 19, 2019

No description provided.

@mickr mickr requested a review from a team as a code owner December 19, 2019 00:24
@boxcla
Copy link

boxcla commented Dec 19, 2019

Verified that @mickr has signed the CLA. Thanks for the pull request!

jstoffan
jstoffan previously approved these changes Dec 19, 2019
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR title to reflect the commit message?

src/lib/viewers/archive/ArchiveExplorer.js Outdated Show resolved Hide resolved
src/lib/viewers/archive/ArchiveExplorer.js Outdated Show resolved Hide resolved
@jstoffan jstoffan self-requested a review December 19, 2019 00:28
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add some tests.

@jstoffan jstoffan self-requested a review December 19, 2019 00:28
@mickr mickr changed the title archive-sortable-columns feat(archive): Add sortable columns to ArchiveExplorer Dec 19, 2019
@mickr
Copy link
Contributor Author

mickr commented Dec 19, 2019

@jstoffan tests are coming

src/lib/viewers/archive/ArchiveExplorer.js Outdated Show resolved Hide resolved
src/lib/viewers/archive/ArchiveExplorer.js Outdated Show resolved Hide resolved
src/lib/viewers/archive/constants.js Show resolved Hide resolved
mxiao6
mxiao6 previously approved these changes Dec 19, 2019
@mickr mickr merged commit 477300a into box:master Dec 19, 2019
@mickr mickr deleted the archive-sortable-columns branch January 6, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants