Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): Exit annotations mode when enter fullscreen #1196

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Apr 13, 2020

No description provided.

@mxiao6 mxiao6 requested a review from a team as a code owner April 13, 2020 23:55
this.annotator.emit(ANNOTATOR_EVENT.setVisibility, false);

this.annotator.toggleAnnotationMode(AnnotationMode.NONE);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does passing nothing here work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does passing nothing here work?

No, it won't work because it sets state to undefined instead of 'none';

@mergify mergify bot merged commit c689e42 into box:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants