test(jest): Migrate all unit tests from Karma to Jest #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
commented
Sep 23, 2020
jstoffan
commented
Sep 23, 2020
mxiao6
previously approved these changes
Sep 24, 2020
ConradJChan
reviewed
Sep 24, 2020
ConradJChan
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Notes
I plan to convert the remaining test suites in the next couple days, but I'd like to merge this batch relatively soon to avoid further conflicts with other PRs. My only remaining concern is whether this will run properly on our CI/CD build agents, but I don't think I can test that until after I merge.