Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Upgrade highlightjs to 9.18.1 #1328

Merged
merged 2 commits into from
Feb 22, 2021
Merged

build(deps): Upgrade highlightjs to 9.18.1 #1328

merged 2 commits into from
Feb 22, 2021

Conversation

ConradJChan
Copy link
Contributor

Tested against the Sanity folder for all browsers

@ConradJChan ConradJChan requested a review from a team as a code owner February 12, 2021 21:13
jstoffan
jstoffan approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the commit message be more general, since we're updating multiple libraries?

src/third-party/text/2.64.0/remarkable.min.js Show resolved Hide resolved
@ConradJChan
Copy link
Contributor Author

This commit is just for highlightjs, I'll do separate commits for remarkable and papaparse

@jstoffan
Copy link
Collaborator

Gotcha. The assets copied over from the prior version bamboozled me. LGTM

@mergify mergify bot merged commit 4f70945 into box:master Feb 22, 2021
@ConradJChan ConradJChan deleted the upgrade-highlightjs-9.18.1 branch February 22, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConradJChan @jstoffan