feat(model3d): Basic React controls #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
May 3, 2021
| }; | ||
| }); | ||
|
|
||
| this.renderer.setAnimationClip(this.animationClips[0].id); |
There was a problem hiding this comment.
Should we be acting on renderer inside of a controls-specific method?
There was a problem hiding this comment.
Ideally not, but it was being done previously in a more roundabout way -- L282 sets the animation clip => Model3DControls would emit a EVENT_SELECT_ANIMATION_CLIP event => handleSelectAnimationClip which acts on the renderer
added 2 commits
May 3, 2021 12:36
jstoffan
previously approved these changes
May 3, 2021
added 2 commits
May 3, 2021 14:36
jstoffan
previously approved these changes
May 3, 2021
src/lib/viewers/box3d/model3d/__tests__/Model3DControlsNew-test.tsx
Outdated
Show resolved
Hide resolved
jstoffan
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial React rewrite of Model3DViewer controls
TODO:
Before:
After:
