Fix: Preview well-formed file in offline (fixes #793) #799
Conversation
|
Hi @stas-dolgachov, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
|
CLA signed |
src/lib/Preview.js
Outdated
| getTokens(this.file.id, this.previewOptions.token) | ||
| .then(this.handleTokenResponse) | ||
| .catch(this.handleFetchError); | ||
| const couldPreviewOfflineWithoutToken = typeof fileIdOrFile === 'object' && this.options.skipServerUpdate; |
There was a problem hiding this comment.
Can you rename this to something starting with is? maybe isOfflinePreview
src/lib/Preview.js
Outdated
| @@ -798,6 +803,9 @@ class Preview extends EventEmitter { | |||
|
|
|||
| // Load from cache if the current file is valid, otherwise load file info from server | |||
| if (checkFileValid(this.file)) { | |||
| /* Save file in cache. This also adds the 'ORIGINAL' representation. | |||
There was a problem hiding this comment.
Change comment style to use // instead of /*
src/lib/__tests__/Preview-test.js
Outdated
| @@ -1002,6 +1002,15 @@ describe('lib/Preview', () => { | |||
| expect(preview.retryTimeout).to.equal(undefined); | |||
| }); | |||
|
|
|||
| it('should load preview when a well-formed file object is passed and server update should be skipped', () => { | |||
| const previewOptions = { skipServerUpdate: true }; | |||
| preview.parseOptions(previewOptions); | |||
There was a problem hiding this comment.
Since we are unit testing load, you shouldn't call parseOptions. Instead set the required fields on the preview object
There was a problem hiding this comment.
Thanks so much for fixing this!
@stas-dolgachov: One thing I would note is that if your use case is to allow users to preview files offline, you will probably also need to set the preview option disableEventLog to true. This will disable Preview event logging requests.
skipServerUpdate only prevents the load from server and any server updates.
Hello guys,
This pull request fixes issue - #793
To remind you, it is required to preview well-formed files in offline mode without internet connection.
I am looking forward getting a feedback from you.
Thank you in advance