Chore: Allow load metrics emission without file info #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @JustinHoldstock has signed the CLA. Thanks for the pull request! |
jeremypress
reviewed
Aug 15, 2018
| @@ -44,7 +44,6 @@ export const ERROR_CODE = { | |||
| FLASH_NOT_ENABLED: 'error_flash_not_enabled' | |||
| }; | |||
|
|
|||
| export const PREVIEW_LOAD_EVENT = ''; | |||
There was a problem hiding this comment.
Why are we removing this?
There was a problem hiding this comment.
It's not used anywhere AND it's an empty string
There was a problem hiding this comment.
We now use the below LOAD_METRIC.previewLoadEvent
jeremypress
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for file info to be request external to preview, and still report timings.
Note: Updates are required in Box UI Elements before this can be merged, otherwise false reports will be generated.