Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace request library with @cypress/request #860

Merged
merged 4 commits into from
Oct 26, 2023
Merged

feat: Replace request library with @cypress/request #860

merged 4 commits into from
Oct 26, 2023

Conversation

congminh1254
Copy link
Member

Closes: SDK-3403

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6652248147

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.669%
Totals Coverage Status
Change from base Build 6572048299: 0.0%
Covered Lines: 2956
Relevant Lines: 3058
💛 - Coveralls

mhagmajer
mhagmajer approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mhagmajer mhagmajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@congminh1254 congminh1254 merged commit d365ae8 into main Oct 26, 2023
12 checks passed
@congminh1254 congminh1254 deleted the replace-cypress-request branch October 26, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhagmajer mhagmajer mhagmajer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @mhagmajer