fix(sidebar): Don't display @mentions without getMentionWithQuery prop (

#746)
box · Jan 18, 2019 · ba8c418 · ba8c418
1 parent e7880a3
commit ba8c418
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/elements/content-sidebar/activity-feed/approval-comment-form/ApprovalCommentForm.js b/src/elements/content-sidebar/activity-feed/approval-comment-form/ApprovalCommentForm.js
@@ -201,7 +201,7 @@ class ApprovalCommentForm extends React.Component<Props, State> {
             approverSelectorContacts,
             className,
             createTask,
-            getMentionWithQuery = noop,
+            getMentionWithQuery,
             intl: { formatMessage },
             isDisabled,
             isOpen,

diff --git a/...content-sidebar/activity-feed/approval-comment-form/__tests__/ApprovalCommentForm-test.js b/...content-sidebar/activity-feed/approval-comment-form/__tests__/ApprovalCommentForm-test.js
@@ -395,6 +395,17 @@ describe('elements/content-sidebar/ActivityFeed/approval-comment-form/ApprovalCo
         expect(content).toEqual('');
     });
 
+    test('should not display trigger @mention selector when getMentionQuery prop is empty', () => {
+        const wrapper = render({ getMentionWithQuery: null });
+
+        expect(
+            wrapper
+                .find('DraftJSMentionSelector')
+                .at(0)
+                .prop('onMention'),
+        ).toEqual(null);
+    });
+
     describe('handleApproverSelectorInput()', () => {
         test('should call getApproverWithQuery() when called', () => {
             const value = 'test';