fix: Fix event:poll polling-interval
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjankowski
reviewed
Nov 21, 2022
| @@ -20,7 +20,7 @@ class EventsPollCommand extends BoxCommand { | |||
| options.endDate = flags['end-date']; | |||
| } | |||
| if (flags['polling-interval']) { | |||
| options.pollingInterval = flags['polling-interval']; | |||
There was a problem hiding this comment.
Shouldn't we differentiate here the enterprise flag enabled, where for getEnterpriseEventStream method we should pass pollingInterval param, and getEventStream method where we have fetchInterval?
I'm afraid that this change will fix getEventStream but will break getEnterpriseEventStream
arjankowski
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #418 & SDK-2725
This bug relating to wrong field passed to Node SDK, and the timing unit in Node SDK is using milliseconds but not seconds.