feat: add max-items, improve list endpoints performance
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwwoda
changed the title
max-items, improve list endpoints perfmax-items, improve list endpoints performance
Pull Request Test Coverage Report for Build 5044056613
💛 - Coveralls |
arjankowski
reviewed
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added max-items flag that could be used to limit number of items returned by list endpoints. Most of them should support this flag.
Improved performance of list endpoints by providing limit of 1000 by default (instead of 100 which is used by the backend if no limit is provided).
Tests for GetFolderItems for 11k records
Before: avg 133s
After: avg 85s