Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from @foliojs-fork and back to the now up to date @foliojs, fixing a critical vulnerability on minimist #2492

Closed
AnthonyLenglet opened this issue Oct 17, 2022 · 1 comment · May be fixed by #2493
Closed

Move away from @foliojs-fork and back to the now up to date @foliojs, fixing a critical vulnerability on minimist #2492

AnthonyLenglet opened this issue Oct 17, 2022 · 1 comment · May be fixed by #2493

Comments

@AnthonyLenglet
Copy link

pdfmake > @foliojs-fork/linebreak > brfs > quote-stream > minimist@1.1.3

This version of minimist has a critical vulnerability related to prototype pollution
GHSA-xvch-5gv4-984h

it looks like this fork was originally made to remediate the lack of updated version on npm, which has since been fixed
foliojs/linebreak#24 (comment)

the updated version in the official, non-forked version, includes this commit that removes the brfs dependency completely, hence fixing the vulnerability
foliojs/linebreak@ac397ca#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
@AnthonyLenglet AnthonyLenglet mentioned this issue Oct 17, 2022
Open
@liborm85
Copy link
Collaborator

liborm85 commented Mar 9, 2024

Fixed in version 0.2.10.

@liborm85 liborm85 closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate away from the fork of foliojs packages AnthonyLenglet/pdfmake
2 participants
@liborm85 @AnthonyLenglet