From ab37581d2d990736b9ea52debc0f7cdca3915483 Mon Sep 17 00:00:00 2001 From: Maciej Barelkowski Date: Tue, 25 Jun 2024 13:51:27 +0200 Subject: [PATCH] deps: update to `diagram-js@14.7.2` fix: remove incorrect attribute in replace menu Related to https://github.com/camunda/camunda-modeler/issues/4383 --- package-lock.json | 15 +++++++------ package.json | 2 +- .../popup-menu/ReplaceMenuProviderSpec.js | 22 +++++++++++++++++++ 3 files changed, 31 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 78274b68ac..b281bf0af4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10,7 +10,7 @@ "license": "SEE LICENSE IN LICENSE", "dependencies": { "bpmn-moddle": "^8.1.0", - "diagram-js": "^14.7.1", + "diagram-js": "^14.7.2", "diagram-js-direct-editing": "^3.0.1", "ids": "^1.0.5", "inherits-browser": "^0.1.0", @@ -3549,9 +3549,10 @@ "dev": true }, "node_modules/diagram-js": { - "version": "14.7.1", - "resolved": "https://registry.npmjs.org/diagram-js/-/diagram-js-14.7.1.tgz", - "integrity": "sha512-XSWuB35iRuKPUVdYdArJb7OimI1oGj61M/7AtyfyS9uwlW//Z7edm4/yNbEUA4MEGhHJZbzg3wLexB1g2N/RmA==", + "version": "14.7.2", + "resolved": "https://registry.npmjs.org/diagram-js/-/diagram-js-14.7.2.tgz", + "integrity": "sha512-K0/SqaG5Uz1AZdubnPKXbwl8E9nQ4qhzUekzsEyDNwjyHzRdwabHqSZ1OeSkoSUDAURtDuebLglJSNnl2xoJAA==", + "license": "MIT", "dependencies": { "@bpmn-io/diagram-js-ui": "^0.2.3", "clsx": "^2.1.0", @@ -18176,9 +18177,9 @@ "dev": true }, "diagram-js": { - "version": "14.7.1", - "resolved": "https://registry.npmjs.org/diagram-js/-/diagram-js-14.7.1.tgz", - "integrity": "sha512-XSWuB35iRuKPUVdYdArJb7OimI1oGj61M/7AtyfyS9uwlW//Z7edm4/yNbEUA4MEGhHJZbzg3wLexB1g2N/RmA==", + "version": "14.7.2", + "resolved": "https://registry.npmjs.org/diagram-js/-/diagram-js-14.7.2.tgz", + "integrity": "sha512-K0/SqaG5Uz1AZdubnPKXbwl8E9nQ4qhzUekzsEyDNwjyHzRdwabHqSZ1OeSkoSUDAURtDuebLglJSNnl2xoJAA==", "requires": { "@bpmn-io/diagram-js-ui": "^0.2.3", "clsx": "^2.1.0", diff --git a/package.json b/package.json index 11dedae28b..b4b4c7ea0e 100644 --- a/package.json +++ b/package.json @@ -112,7 +112,7 @@ }, "dependencies": { "bpmn-moddle": "^8.1.0", - "diagram-js": "^14.7.1", + "diagram-js": "^14.7.2", "diagram-js-direct-editing": "^3.0.1", "ids": "^1.0.5", "inherits-browser": "^0.1.0", diff --git a/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js b/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js index e74331a947..ae698bd5b7 100644 --- a/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js +++ b/test/spec/features/popup-menu/ReplaceMenuProviderSpec.js @@ -1,3 +1,5 @@ +import { expectToBeAccessible } from '@bpmn-io/a11y'; + import { bootstrapModeler, getBpmnJS, @@ -1842,6 +1844,26 @@ describe('features/popup-menu - replace menu provider', function() { }); + describe('a11y', function() { + + beforeEach(bootstrapModeler(diagramXMLReplace, { modules: testModules })); + + + it('should report no violations', inject(async function(elementRegistry) { + + // given + const startEvent = elementRegistry.get('StartEvent_1'); + + // when + openPopup(startEvent); + + // then + const container = getMenuContainer(); + await expectToBeAccessible(container); + })); + }); + + describe('integration', function() {