Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make popup menu WCGA 2.1 compliant #871

Closed
nikku opened this issue Mar 18, 2024 · 3 comments · Fixed by #874
Closed

Make popup menu WCGA 2.1 compliant #871

nikku opened this issue Mar 18, 2024 · 3 comments · Fixed by #874
Assignees
Labels
a11y enhancement New feature or request

Comments

@nikku
Copy link
Member

nikku commented Mar 18, 2024

Is your feature request related to a problem? Please describe.

Currently the popup menu is a keyboard trap that is insufficiently indicated to assistive technology (screen readers), it violates no-keyboard-trap.

Describe the solution you'd like

The popup editor is clearly indicated as a keyboard trap with ESC (cancel) or ENTER (to select action) being the two promoted navigation actions.

Describe alternatives you've considered

Do not trap TAB but instead only trap arrow keys. Tab will focus individual entries in the select, and tabbing out of the component will close it.

Additional context

Found via https://github.com/camunda/web-modeler/issues/7929#issuecomment-2003338026.


Child of https://github.com/bpmn-io/internal-docs/issues/909

@nikku nikku added enhancement New feature or request a11y labels Mar 18, 2024
@nikku
Copy link
Member Author

nikku commented Mar 18, 2024

I added the following as an alternative, which more clearly follows existing usage patterns (and no-keyboard-trap):

Do not trap TAB but instead only trap arrow keys. Tab will focus individual entries in the select, and tabbing out of the component will close it.

@barmac
Copy link
Member

barmac commented Mar 18, 2024

Drop TAB makes sense to me.

@nikku nikku added the backlog Queued in backlog label Mar 19, 2024
@nikku nikku mentioned this issue Mar 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed backlog Queued in backlog in progress Currently worked on labels Mar 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 22, 2024
@nikku
Copy link
Member Author

nikku commented Mar 22, 2024

#874 ships initial support, we'll iterate if there is more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants