Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain dmn-js ui labels are not translatable #793

Closed
kevin-fong opened this issue Oct 19, 2023 · 0 comments · Fixed by #794
Closed

Certain dmn-js ui labels are not translatable #793

kevin-fong opened this issue Oct 19, 2023 · 0 comments · Fixed by #794
Labels
bug Something isn't working

Comments

@kevin-fong
Copy link
Contributor

kevin-fong commented Oct 19, 2023

Describe the Bug

Certain dmn-js user interface labels are not translatable.

  • Decision Editor > "Move rule" (a html title attribute's value)
  • Decision Editor -> "Add Rule" (a html title attribute's value)
  • Literal Expression Editor -> Variable Name -> "name" (a html placeholder attribute's value)

image

Steps to Reproduce

Steps to reproduce the behavior (using Windows PowerShell):

  1. git clone https://github.com/bpmn-io/dmn-js.git
  2. cd .\dmn-js\
  3. git checkout tags/v14.1.5 (I could not get the develop or master branches to build in my local environment; I'm not a node developer and I don't think I'm properly setup)
  4. npm install
  5. npm run start:translate (this will open the "Karma DEBUG RUNNER" in a web browser)
  6. Enter the Decision Editor for the "Season decision" Decision.
  7. Hover your cursor over the "1" table cell in the leftmost table column and then hover your cursor over the "grid" symbol that appears. Notice that the tooltip that appears is "Move rule" and not "tr(Move rule)".
  8. Hover your cursor over the "+" character/symbol. Notice that the tooltip that appears is "Add Rule" and not "tr(Add Rule)".
  9. Enter the Literal Express Editor for the "It's lit" Literal Expression.
  10. Delete the value that is in the "tr(Variable Name:)" text input. Notice that the placeholder value is "name" and not "tr(name)".
  • The "Move rule" bug traces back to here, I think (it is just a literal value and doesn't use the translation function).
  • The "Add Rule" bug traces back to here, I think (it is just a literal value and doesn't use the translation function).
  • The "name" bug is here, I think (it is just a literal value and doesn't use the translation function).

Expected Behavior

The following dmn-js user interface labels should be translatable:

  • Decision Editor > "Move rule" (a html title attribute's value)
  • Decision Editor -> "Add Rule" (a html title attribute's value)
  • Literal Expression Editor -> Variable Name -> "name" (a html placeholder attribute's value)

Environment

Please complete the following information:

@kevin-fong kevin-fong added the bug Something isn't working label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant