Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Fix linux runtime dependency installation #192

Open
core-ai-bot opened this issue Aug 17, 2021 · 19 comments
Open

[CLOSED] Fix linux runtime dependency installation #192

core-ai-bot opened this issue Aug 17, 2021 · 19 comments

Comments

@core-ai-bot
Copy link
Member

Issue by jasonsanjose
Tuesday Aug 20, 2013 at 05:08 GMT
Originally opened as adobe#305

Fix for adobe/brackets#4720

  • Copies chromium install scripts to symlink libudev, libnss3 and libnspr4 locally into /opt/brackets/ then set LD_LIBRARY_PATH to use the symlinked libraries
  • Creates a new brackets wrapper script that is copied to the staging folder pacakge-root/opt/brackets
  • Creates a new symlink /usr/bin/brackets to point to /opt/brackets/brackets
  • Update dependencies to match google-chrome 28

I've uploaded a 64-bit package for testing here https://github.com/jasonsanjose/brackets-shell/releases/tag/0.30.0-8781. I tested this on a clean ubuntu 13.04 64-bit VM and did not get any libudev or libplc errors.

jasonsanjose included the following code: https://github.com/adobe/brackets-shell/pull/305/commits
@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 05:17 GMT

Tagging @JeffryBooher @redmunds @timburgess @dabungalow to help test.

@core-ai-bot
Copy link
Member Author

Comment by thefirstofthe300
Tuesday Aug 20, 2013 at 07:08 GMT

I installed the linked package but ended up with this error when running brackets.

brackets: libcef_dll/wrapper/libcef_dll_wrapper.cc:121: int CefExecuteProcess(const CefMainArgs&, CefRefPtr<CefApp>): Assertion `false' failed. 
Aborted

It doesn't seem to be related to the dependencies.

@core-ai-bot
Copy link
Member Author

Comment by tttzof351
Tuesday Aug 20, 2013 at 08:10 GMT

The same thing

brackets: libcef_dll/wrapper/libcef_dll_wrapper.cc:121: int CefExecuteProcess(const CefMainArgs&, CefRefPtr): Assertion `false' failed.
Aborted (core dumped)

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 16:11 GMT

Thanks @DaBungalow and @tttzof351 I'll take a look. It could be the new CEF.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 16:46 GMT

Yep. Something got wedged in my build. I did a clean build and everything is working (and tested this time). I've updated the .deb at the link above.

@core-ai-bot
Copy link
Member Author

Comment by thefirstofthe300
Tuesday Aug 20, 2013 at 17:33 GMT

Upon downloading the clean build and on a fresh install of Linux Mint 15, everything works out of the box.

I did some poking around in the file system and didn't find a symlink from libudev.so.0 to libudev.so.1, which seems odd considering everything is working just fine.

@core-ai-bot
Copy link
Member Author

Comment by thefirstofthe300
Tuesday Aug 20, 2013 at 17:35 GMT

Ignore my last comment. I found the symlinks. sheepish grin

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 19:06 GMT

@JeffryBooher, we got feedback from @DaBungalow at least. Want to start the review now or wait for @timburgess too?

@core-ai-bot
Copy link
Member Author

Comment by ghetolay
Tuesday Aug 20, 2013 at 20:34 GMT

Hi,

I'm just testing brackets on ubuntu 13.04. Sprint 29 didn't work but this one works great :)
Now I'm unable to install plugins but that's another story.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Tuesday Aug 20, 2013 at 20:41 GMT

@ghetolay Test with PR #306 which has this PR and Node.js integrated. So it should let you install plugins too :)

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 20:43 GMT

@ghetolay I'm uploading an updated .deb file there now. Give it another 10 min.

@core-ai-bot
Copy link
Member Author

Comment by timburgess
Tuesday Aug 20, 2013 at 22:29 GMT

Installed the .deb on a 'fresh' Ubuntu 12.04 LTS 64bit machine which hasn't had any Brackets dev done on it beforehand. .deb installs and /opt/brackets/Brackets runs as expected. Only question I have is that there is a Brackets and a brackets in /opt/brackets, both with executable permissions - not sure why that is the case.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 22:41 GMT

@timburgess because that's what Chrome does. :)

Brackets is a binary executable and brackets is a shell script to wrap Brackets in order to set the LD_LIBRARY_PATH.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Aug 21, 2013 at 00:44 GMT

Installed and played with it for an afternoon without any problems.

My only concerns are:

  1. The debian package seems to be missing some information such as license. It should say "MIT"
  2. Brackets does not show up for me in the "Ubuntu Software Center". This feels like a must have as usr/share/applications is a little tough to navigate to and we should show it under installed applications if the "Ubuntu Software Center" is used to install it.
  3. The installed version does not have tests enabled. Not sure if we should do this but, since this is a new OS, we should consider enabling and shipping unit tests with the debian package for a while. Just until we have 100% functionality across the board or we get the error -3 taken care of.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Aug 21, 2013 at 00:46 GMT

@jasonsanjose I think this is good to go. Just need @timburgess and @DaBungalow to sign off on it and I'll do the merge.

@core-ai-bot
Copy link
Member Author

Comment by thefirstofthe300
Wednesday Aug 21, 2013 at 00:46 GMT

I say go for it.

On Tue, Aug 20, 2013 at 5:46 PM, Jeff Booher notifications@github.comwrote:

@jasonsanjose https://github.com/jasonsanjose I think this is good to
go. Just need @timburgess https://github.com/timburgess and @DaBungalowhttps://github.com/DaBungalowto sign off on it and I'll do the merge.

—
Reply to this email directly or view it on GitHubhttps://github.com/adobe/pull/305#issuecomment-22988575
.

Danny Seymour
dannyseeless@gmail.com

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Aug 21, 2013 at 00:48 GMT

@jasonsanjose hold the phone... I just got a WSOD on Linux and I wasn't doing anything... I wasn't even using that computer...

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Aug 21, 2013 at 01:00 GMT

Merging

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Aug 21, 2013 at 01:06 GMT

@JeffryBooher

  1. There is more to do here with the metadata. A copyright file should be easy. There's a task here https://trello.com/c/ZoCPy6mD/895-linux-ubuntu-installer-packaging.
  2. Ubuntu Software Center is likely a completely different beast. I'm not sure why it doesn't show up as installed. I don't see chrome there either. Maybe it only shows packages that USC hosts itself?
  3. We don't show tests for installed builds on mac or win either. Users have to run tools/setup_for_hacking.sh in order to point to the git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot