-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] CodeHintManager needs to be smarter about key processing #2417
Comments
Comment by pthiess Reviewed |
Comment by RaymondLim
Otherwise, we do really need to remove the code since lots of keyboard layouts require users to type characters like |
Comment by redmunds
|
Comment by RaymondLim If it is the case, I would like to know the scenario where the keyboard shortcuts gets caught. My guess is that Ian just wants to dismiss code hints when a keyboard shortcut is pressed. We didn't do that in the old design and the code hints keep showing. |
Comment by iwehrman The original idea was to close the hinting session on "complex" editor changes, as can occur as a result of, e.g., cut or paste operations. Perhaps we can find another way to detect such changes. |
Comment by RaymondLim Thanks. I'm removing this particular code so that users can type any characters that require modifier keys. |
Comment by redmunds Confirmed. Closing. |
Comment by RaymondLim Reopen it since pull request #2756 introduced #2820 and we have to revert my changes. Since we currently don't have any code hints that have to be triggered with |
Comment by redmunds This does not affect any current code hints. Closing. |
Issue by redmunds
Monday Jan 14, 2013 at 19:48 GMT
Originally opened as adobe/brackets#2539
This was reported by
@
zoufahl when developing CSS Code Hints.In CodeHintManager
handleKeyEvent
function is this block of code:The problem is when the code hint session starts on keyup and the user is trying to insert a "{" from a German keyboard (which is Alt+8). Maybe a keybinding lookup would make more sense here. Consult
@
RaymondLim.The text was updated successfully, but these errors were encountered: