-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Fix issue #2306 (Recent projects close arrow fail to close without mouse move) #2467
Comments
Comment by WebsiteDeveloper this change seems to fix the issue but i couldn't find out why |
Comment by WebsiteDeveloper It seems a simple change in the checkHovers() functions also fixes the problem: $(".recent-folder-link", this).triggerHandler("mouseenter"); This works: $(this).triggerHandler("mouseenter"); Instead of all links just trigger mouseenter on the current li |
Comment by WebsiteDeveloper
|
Comment by jbalsas Hi I've tried your solution and if I switch the line in |
Comment by WebsiteDeveloper
|
Comment by jbalsas I've tested it on this branch merged with master, and alone just in master and in both cases the close icon won't show.
If we could get it to work, I'd rather have something like what you suggest, as to me, it looks closer to the original intent of the code. |
Comment by WebsiteDeveloper Actually when i print out |
Comment by jbalsas Sorry, but it's still not working for me. I also can't quite see why triggering it from the Could you maybe put your code together in a branch and push it to your github account so I could clone it and check it myself? |
Comment by WebsiteDeveloper i'll push a branch tomorrow |
Comment by WebsiteDeveloper
|
Comment by jbalsas
Are you by any chance on Windows? I'm running on MacOS, so maybe this is somehow platform-specific... I don't have access to any windows machine to check it out so maybe someone else could pitch in... |
Comment by WebsiteDeveloper
|
Comment by redmunds
Merging. |
Issue by jbalsas
Thursday Jan 17, 2013 at 22:23 GMT
Originally opened as adobe/brackets#2590
This is a possible fix for issue #2306. It changes
click
tomouseup
as the event to close an entry in the list of recent projects.It seems that jquery
click
event is not triggered if the mouse is already over the svg element when the old one is removed and the new one rendered, butmouseup
is.I'd say it has something to do with the lack of
mouseenter
, but I haven't been able to replicate it anywhere else outside this.jbalsas included the following code: https://github.com/adobe/brackets/pull/2590/commits
The text was updated successfully, but these errors were encountered: