Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] [cmv3] Mac w/mouse - scrollbars appear incorrectly in inline editors #2660

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

[CLOSED] [cmv3] Mac w/mouse - scrollbars appear incorrectly in inline editors #2660

core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by gruehle
Thursday Feb 07, 2013 at 23:01 GMT
Originally opened as adobe/brackets#2806

Steps to repro

  1. Plug a mouse into your mac
  2. Launch Brackets, and open the brackets src folder. Make sure the Brackets window is not too wide.
  3. Open brackets.js
  4. On ~line 156, put the cursor in setEditorHolder and press Cmd-E. Inline editor opens and a horizontal scrollbar appears in editor (if the horizontal scrollbar isn't visible, make the window narrower until it is shown).
  5. Scroll down to the bottom of the file
  6. Scroll back up and look at the inline editor

Results
The inline editor show an empty vertical scrollbar, no horizontal scrollbar, and the line numbers are indented to the right.

Expected
Inline editor should look the same as when it was first opened.

InlineScrollbar
@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Feb 07, 2013 at 23:59 GMT

Reviewed. To me for sprint 20. Potentially deferrable if it's risky to fix.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Feb 08, 2013 at 00:51 GMT

I can reproduce it on Windows with the following steps.

  1. Open index.html from Getting Started project.
  2. Set cursor on h1 tag and press Ctrl+E to open inline editor.
  3. Drag the vertical scroll bar down and then up. (or you can use Ctrl+End, then Ctrl+Home in main editor.)

Now you see an empty scroll bar inside the inline editor and line numbers inside the inline are drawn over the content of inline editor.

InlineScrollbar

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Feb 08, 2013 at 05:29 GMT

Similar to my comment in #2782, we already have code that's supposed to handle refreshing the child editor when a widget gets re-added to the DOM. Perhaps there's a similar underlying bug going on here.

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Feb 08, 2013 at 05:47 GMT

Aha. It looks like the underlying issue is codemirror/codemirror5#1226. I have a workaround.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Friday Feb 08, 2013 at 18:53 GMT

Confirmed fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot