Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] HTML tag highlight added. #4173

Open
core-ai-bot opened this issue Aug 29, 2021 · 18 comments
Open

[CLOSED] HTML tag highlight added. #4173

core-ai-bot opened this issue Aug 29, 2021 · 18 comments

Comments

@core-ai-bot
Copy link
Member

Issue by sathyamoorthi
Thursday Jul 18, 2013 at 06:25 GMT
Originally opened as adobe/brackets#4504

Tag highlight functionality added.

Image

_some tracks_
Google Group Discussion
Trello Card
adobe/brackets#3069

Code mirror's matchTags extension only highlight the other tag. In the above screenshot, i put cursor on start tag <form, but it only highlights the other tag </form>. If you want to to highlight both tags, i can rewrite this extension for brackets.

sathyamoorthi included the following code: https://github.com/adobe/brackets/pull/4504/commits
@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Jul 18, 2013 at 17:27 GMT

To@larz0 to review the UX and make suggestions.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Thursday Jul 18, 2013 at 20:08 GMT

This is awesome@sathyamoorthi. I'm wondering if we could make it so that it highlights the end tag when the cursor is anywhere within > and < so that we don't have to consciously target the tag name when the start tag is long due to attributes. Thoughts?

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Friday Jul 19, 2013 at 04:57 GMT

@larz0 ahhh. yes. let me check this.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Thursday Jul 25, 2013 at 08:49 GMT

@larz0 Committed necessary changes to CodeMirror. Please check now.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Thursday Jul 25, 2013 at 16:51 GMT

@sathyamoorthi the UX is much better now, thanks. We'll get someone to review the code.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Aug 16, 2013 at 16:56 GMT

@sathyamoorthi@larz0 can we highlight both tags? I find it a little unbalanced if we just highlight the one. We already highlight open and close brace and other editors highlight open and close tags.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Friday Aug 16, 2013 at 17:09 GMT

@JeffryBooher Sounds good.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Friday Aug 16, 2013 at 17:43 GMT

@JeffryBooher See this pull request codemirror/codemirror5#1653.

@marijnh commented.

"I prefer the way things look when only the 'other' tag is highlighted, so I'm going to keep the
addon in the distribution the way it is."

So i could ask him or gave pull request to CodeMirror to add an option to highlight both tags OR i can customize that add-on for brackets.

Need your opinion.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Sunday Aug 25, 2013 at 03:47 GMT

@njx what do you think? Larz and I agree that it looks more balanced with both open and close tags highlighted but which option do we go with? I'm not as familiar with how code-mirror works and the politics around changing the code-mirror code base but it sounds like we may have to do the work ourselves. @sathyamoorthi already has some of the code done (sans the performance enhancement) it would be pretty straight forward to just take that change.

I guess the other option is that we fork the addon and create a new one with a different name and it's never committed back to code-mirror.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Aug 25, 2013 at 03:54 GMT

Maybe Marijnh would accept the change it was made as an option on the addon, and not active by default? Which would leave the behavior as it is by default and add the one we desire with an additional option. Might be worth asking him first.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Sunday Aug 25, 2013 at 03:56 GMT

@TomMalbran@JeffryBooher yes. i prefer this. Let me ask him in codemirror discussion. He is nice guy, he'll do it. I hope.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Sunday Aug 25, 2013 at 03:58 GMT

@sathyamoorthi excellent!

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Monday Aug 26, 2013 at 08:56 GMT

@marijnh accepted this patch.
codemirror/codemirror5#1781

@JeffryBooher@larz0 I committed an option to highlight both tags. Please check.
sathyamoorthi/brackets@0cb9eb7

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Thursday Aug 29, 2013 at 05:01 GMT

Nominating for Sprint 31

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 21:10 GMT

@sathyamoorthi can you merge master into this branch so I can test it with the latest codemirror?

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 21:14 GMT

@sathyamoorthi disregard. I just merged your changes into a new branch and merged master in to that. Looks good!

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 21:26 GMT

Merging this into master. Looks like the travis build error is benign.

@core-ai-bot
Copy link
Member Author

Comment by lovebdsobuj
Thursday Apr 16, 2015 at 14:26 GMT

Tag Highlight very important and useful Extension...
Like this any Extension have Adobe Brackets...?
https://github.com/facelessuser/BracketHighlighter?files=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot