Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Dutch Translation #4941

Open
core-ai-bot opened this issue Aug 30, 2021 · 10 comments
Open

[CLOSED] Dutch Translation #4941

core-ai-bot opened this issue Aug 30, 2021 · 10 comments

Comments

@core-ai-bot
Copy link
Member

Issue by Wouter92
Saturday Sep 28, 2013 at 16:46 GMT
Originally opened as adobe/brackets#5372


With this pull request a Dutch translation is added to the Brackets application.
Also in the root strings.js the name for this language is added and translated in the dutch strings.js


Wouter92 included the following code: https://github.com/adobe/brackets/pull/5372/commits

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Sunday Sep 29, 2013 at 06:55 GMT


@Wouter92 you should find someone to do a peer review of your translation.

@core-ai-bot
Copy link
Member Author

Comment by Wouter92
Sunday Sep 29, 2013 at 08:40 GMT


@WebsiteDeveloper Does the reviewer need to have a GitHub account or can I let this be reviewed offline?

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Sunday Sep 29, 2013 at 09:35 GMT


@Wouter92 i think it would be best if he had one to review it in this pull request.

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Friday Nov 08, 2013 at 17:50 GMT


I'll go ahead and merge this based on verification using automatic translation.@Wouter92 Could you merge master again?

@core-ai-bot
Copy link
Member Author

Comment by Wouter92
Friday Nov 08, 2013 at 22:04 GMT


What do you mean? There is nothing changed from my master since then if that's what you mean.

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Friday Nov 08, 2013 at 22:08 GMT


src/nls/root/strings.js
src/nls/de/strings.js
src/nls/strings.js

These have changed in brackets master. Github disables merge per browser in these situations. If you could merge the latest brackets master into your branch that would help. You may also look if there have been string changes in english since you submitted your request that you'd want to incorporate into your translation.

@core-ai-bot
Copy link
Member Author

Comment by Wouter92
Friday Nov 08, 2013 at 22:47 GMT


I merged everything but I will add those changes in those files later on, because I've not much time to do this right now.

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Saturday Nov 09, 2013 at 00:15 GMT


Dank u@Wouter92 - merging

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Saturday Nov 09, 2013 at 01:03 GMT


@couzteau As far as I can see we changed some submodule commit refs that shouldn't be changed.

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Saturday Nov 09, 2013 at 01:27 GMT


Yes, that was an accident. but it's fixed already with 6ca65121a00de444e0a8f157e16dcdaf9b4620cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant