Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Modal Window glitch #5028

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments
Open

[CLOSED] Modal Window glitch #5028

core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by larz0
Thursday Oct 10, 2013 at 22:08 GMT
Originally opened as adobe/brackets#5476


To reproduce:
Click on a non-supported file or install Brackets Git and commit a file using Brackets Git.

screen shot 2013-10-10 at 2 32 43 pm

screen shot 2013-10-10 at 2 32 52 pm

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Oct 10, 2013 at 23:02 GMT


This was most likely caused by https://github.com/adobe/brackets/pull/5399.`@`WebsiteDeveloper Can you take a look? This may be Mac-only.

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Friday Oct 11, 2013 at 05:11 GMT


@redmunds i will look at it but if it doesn't reproduce on windows someone else will have to test.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Oct 11, 2013 at 05:33 GMT


@WebsiteDeveloper
Yes, I can reproduce it on Mac and by reverting your change in the following rule does fix the issue. 560px -> 580px

.modal-body, .modal-header, .modal-footer {
    /* See styles/bootstrap/patterns.less .modal class.
       Pushing this value down to .modal-header and .modal-body
       to allow the overall modal to take the width of the footer */
    width: 560px;
}

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Friday Oct 11, 2013 at 10:19 GMT


This issue also reproduce on Win OS with latest build 0.33.0-9819. I think Install extension dialog issue I met today is caused by the same reason. Here is the snapshot for reference:
111

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Friday Oct 11, 2013 at 10:44 GMT


@RaymondLim i will put up a pull, this change fixes the install extension dialog issue and the error issue.
The git dialog issue is an issue with the extension, because the center their dialog via javascript.
I will open an issue with the extensions repo and maybe submit a pull.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Oct 14, 2013 at 14:20 GMT


Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant