-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaying requests without proto definitions #105
Comments
Hey @rithvikvibhu, yes this is exactly what grpc-replay does (or at least should do!) You can see an example of this in the integration test:
The messages in https://github.com/bradleyjkemp/grpc-tools/blob/master/integration_test/test-dump.json are replayed even though there are no proto descriptors for some of them. If grpc-replay doesn't have a descriptor for a message it will just send the raw message directly.
Are you seeing issues with this feature? |
Ah I see the problem now! grpc-dump is omitting the "raw_message" field when it is empty but this is wrong: the empty string is a valid raw message (i.e. it's the empty message). #106 should fix this issue |
Hey, I tested this change, but it still says no resolver available when proto defs aren't given. But the dump now has Manually editing the dump from |
Is there any way to replay requests dumped by
grpc-dump
when the description files / definitions are not known?Won't the
raw_message
field in the dump be enough to resend it (without modifications)?The text was updated successfully, but these errors were encountered: