[no-unused-vars] false positive with import used in type

[wesleymostien]

As you can see in the screenshot, eslint reports an error on 'webpack' while it is used in a type notation.

[macklinu]

I added the following test locally as a valid test case, and all tests passed:

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
index c470d3c..0bfc682 100644
--- a/tests/lib/rules/no-unused-vars.js
+++ b/tests/lib/rules/no-unused-vars.js
@@ -316,6 +316,13 @@ import { Another } from 'some';
 interface A extends Nullable<SomeOther> {
     do(a: Nullable<Another>);
 }
+        `,
+        `
+import * as webpack from 'webpack';
+
+const webpackConfig: webpack.Configuration = {};
+
+return webpackConfig;
         `
     ],
 

Nothing in that snippet is being reported as unused. Are you still experiencing this issue with the latest version of eslint-plugin-typescript, and if so, could you please include your ESLint config?

[bradzacher]

closing as we are unable to reproduce, and there has been no response from OP.

[JPeer264]

I wanted to create a new issue with the exact same title. Maybe it is better to post it here?

// next line is an error
import { HTMLAttributes } from 'react';

type SomeType = HTMLAttributes<HTMLButtonElement>;

[bradzacher]

Check your parser version.
Plugin version 0.14.0 only supports up to parser v17 (i think it was 17?)

[JPeer264]

Oh. I am currently on v21. So with the plugin version v1 the current parser should be supported right?

[bradzacher]

Yes. With the v1 release we have made it possible for us to control the parser version to help prevent mismatches.
And we have upgraded and handled the changes introduced in parser v21.

We're close to the v1 release!

[eddiemonge]

How close?

[bradzacher]

Have a look at the pinned 1.0.0 issue (#151). You can try out the RC now.

[armano2]

there are still some errors in no-unused-vars and so on, we need new release of parser :)