Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update across repos to latest linting rules #74

Open
alessandrofelder opened this issue Apr 26, 2024 · 0 comments
Open

[Feature] Update across repos to latest linting rules #74

alessandrofelder opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Apr 26, 2024

Is your feature request related to a problem? Please describe.
Linting is inconsistent across BrainGlobe and lacks the latest switch to ruff.

Describe the solution you'd like
This issue will be addressed when all BrainGlobe repos follow at least the minimal ruff linting rules of the NIU cookiecutter. Some or all repos may follow additional rules, such a ["D"] to check docstrings.

The relevant PR, containing the switch from black/flake8 to ruff, and the introduction of additional pre-commit rules is https://github.com/neuroinformatics-unit/movement/pull/156/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9

Describe alternatives you've considered

Additional context
Related to #48 and #9.

Starting from an older repo (e.g. brainrender?) with experimentation might help understand which rules would make sense for BrainGlobe.

Ideally, (as a later step) we'd move as much as possible of the linting rules and other pre-commit config to an organisational level, in the .github repository.
Inspiration for this could be gained from https://github.com/UCL-MIRSG/.github/tree/main/precommit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant