Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep ads state when disabling Brave Ads #10097

Closed
tmancey opened this issue Jun 5, 2020 · 3 comments · Fixed by brave/brave-core#5749
Closed

Keep ads state when disabling Brave Ads #10097

tmancey opened this issue Jun 5, 2020 · 3 comments · Fixed by brave/brave-core#5749
Assignees
@tmancey
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 5, 2020

Keep ads state when disabling Brave Ads. Users will be able to reset ads state as part of #10064
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes feature/ads labels Jun 5, 2020
@tmancey tmancey self-assigned this Jun 5, 2020
@tmancey tmancey mentioned this issue Jun 5, 2020
Merged
32 tasks
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 5, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 30, 2020 •
edited
Loading

Reset ads can be tested only when the issue #10934 is fixed. Please note this issue is blocked for only windows platform.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 31, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verification passed on


Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.112 x64 build

  • Verified viewing an ad, then toggling ads off and then back on doesn't rest Estimated pending rewards and Ad notifications received to zero

Verification passed on Samsung Tab A with Android 10 running 1.12.112 x64 build

  • Verified viewing an ad, then toggling ads off and then back on doesn't rest Estimated pending rewards and Ad notifications received to zero

@srirambv srirambv mentioned this issue Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Keep ads state when disabling Brave Ads brave/brave-core
5 participants
@tmancey @srirambv @LaurenWags @btlechowski @GeetaSarvadnya