Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Upgrade from Chromium 84.0.4147.85 to Chromium 84.0.4147.89. #10714

Closed
mkarolin opened this issue Jul 13, 2020 · 3 comments · Fixed by #10715 or brave/brave-core#6066
Closed

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/84.0.4147.85..84.0.4147.89?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

Removing OS/Android tag and logging #10732 for Android per discussion with @srirambv

@LaurenWags LaurenWags removed the OS/Android Fixes related to Android browser functionality label Jul 14, 2020
@LaurenWags
Copy link
Member

@brave/legacy_qa when running through the above, please make sure that we check the area's @mkarolin mentioned via #10364 (comment).

@LaurenWags
Copy link
Member

LaurenWags commented Jul 14, 2020

Verified passed with

Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified various items on brave://settings as per Upgrade from Chromium 83 to Chromium 84 #10364 (comment):
    • Confirmed Brave colors defaults to same as macOS (on Mojave) and can be modified to both Light or Dark. Confirmed selection is retained on restart.
    • Confirmed Show Brave suggested sites in autocomplete suggestions defaults to off and can be enabled. Confirmed selection is retained on restart.
    • Confirmed Hide Brave Rewards button defaults to off and can be enabled. Confirmed selection is retained on restart.
    • Confirmed Always show bookmarks on New Tab page is defaults to on and can be disabled. Confirmed selection is retained on restart.
    • Generally confirmed able to make modifications to brave://settings/newTab (did encounter known issue [Desktop] Enabling Brave Rewards widget via settings page doesn't enable it in NTP #10067)
    • Generally confirmed able to make modifications to brave://settings/shields and they were retained on browser restart. Confirmed visiting a site and shields defaulted to these updated settings.
    • Generally confirmed able to make modifications to brave://settings/socialBlocking and they were retained on browser restart. Confirmed visiting https://fmarier.github.io/brave-testing/social-widgets.html showed expected items.
    • Generally confirmed brave://settings/extensions contains same settings as previous version. Confirmed defaults remained the same.
    • Confirmed brave://settings/braveHelpTips still contains Wayback machine setting which defaults to on and can be disabled. Confirmed selection is retained on restart.
    • Confirmed clearing browsing data on exit worked as expected
    • Spot checked changing settings in brave://settings/content
  • Additional testing done with 1.11.94 and can be found here: Upgrade from Chromium 84.0.4147.68 to Chromium 84.0.4147.85. #10594 (comment)

Verification passed on


Brave | 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


  • Confirmed Brave colors defaults to same as Windows OS` and can be modified to both Light or Dark. Confirmed selection is retained on restart.
    • Confirmed Show Brave suggested sites in autocomplete suggestions defaults to off and can be enabled. Confirmed selection is retained on restart.
    • Confirmed Hide Brave Rewards button defaults to off and can be enabled. Confirmed selection is retained on restart.
    • Confirmed Always show bookmarks on New Tab page is defaults to on and can be disabled. Confirmed selection is retained on restart.
    • Generally confirmed able to make modifications to brave://settings/newTab (did encounter known issue [Desktop] Enabling Brave Rewards widget via settings page doesn't enable it in NTP #10067)
    • Generally confirmed able to make modifications to brave://settings/shields and they were retained on browser restart. Confirmed visiting a site and shields defaulted to these updated settings.
    • Generally confirmed able to make modifications to brave://settings/socialBlocking and they were retained on browser restart. Confirmed visiting https://fmarier.github.io/brave-testing/social-widgets.html showed expected items.
    • Generally confirmed brave://settings/extensions contains same settings as previous version. Confirmed defaults remained the same.
    • Confirmed brave://settings/braveHelpTips still contains Wayback machine setting which defaults to on and can be disabled. Confirmed selection is retained on restart.
    • Confirmed clearing browsing data on exit worked as expected
    • Spot checked changing settings in brave://settings/content

Verification passed on

Brave 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Verified various items on brave://settings as per Upgrade from Chromium 83 to Chromium 84 #10364 (comment):
    • Confirmed Brave colors defaults to Light and can be modified to both Dark. Confirmed selection is retained on restart.
    • Confirmed Show Brave suggested sites in autocomplete suggestions defaults to off and can be enabled. Confirmed selection is retained on restart.
    • Confirmed Hide Brave Rewards button defaults to off and can be enabled. Confirmed selection is retained on restart.
    • Confirmed Always show bookmarks on New Tab page is defaults to on and can be disabled. Confirmed selection is retained on restart.
    • Generally confirmed able to make modifications to brave://settings/newTab (did encounter known issue [Desktop] Enabling Brave Rewards widget via settings page doesn't enable it in NTP #10067)
    • Generally confirmed able to make modifications to brave://settings/shields and they were retained on browser restart. Confirmed visiting a site and shields defaulted to these updated settings.
    • Generally confirmed able to make modifications to brave://settings/socialBlocking and they were retained on browser restart. Confirmed visiting https://fmarier.github.io/brave-testing/social-widgets.html showed expected items.
    • Generally confirmed brave://settings/extensions contains same settings as previous version. Confirmed defaults remained the same.
    • Confirmed brave://settings/braveHelpTips still contains Wayback machine setting which defaults to on and can be disabled. Confirmed selection is retained on restart.
    • Confirmed clearing browsing data on exit worked as expected
    • Spot checked changing settings in brave://settings/content

@rebron rebron changed the title Upgrade from Chromium 84.0.4147.85 to Chromium 84.0.4147.89. [Desktop] Upgrade from Chromium 84.0.4147.85 to Chromium 84.0.4147.89. Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment