Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flash in Tor Mode #1078

Closed
bsclifton opened this issue Sep 10, 2018 · 3 comments · Fixed by brave/brave-core#624
Closed

Disable flash in Tor Mode #1078

bsclifton opened this issue Sep 10, 2018 · 3 comments · Fixed by brave/brave-core#624
Assignees
@yrliou @riastradh-brave
Labels
browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor plugin/flash QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@bsclifton
Copy link
Member

Was already implemented in browser-laptop with brave/browser-laptop#13396

Test plan

  1. Open a new TOR PT
  2. Visit http://homestarrunner.com/main1.html
  3. Should show flash placeholder
  4. Right click shouldn't bring up context menu to allow flash to run
  5. Enable flash globally
  6. Repeat steps 2 and 3
  7. Should still show flash placeholder and not context menu option should not show

since they are not guaranteed to use proxy settings

related: https://bugs.chromium.org/p/chromium/issues/detail?id=163116
@bsclifton bsclifton added feature/tor browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. labels Sep 10, 2018
@bsclifton bsclifton added this to the 1.x Backlog milestone Sep 10, 2018
@srirambv srirambv mentioned this issue Sep 29, 2018
Closed
@diracdeltas diracdeltas modified the milestones: 1.x Backlog, 1.0 (0.56.x) Sep 29, 2018
@diracdeltas
Copy link
Member

Widevine should also be disabled in Tor mode. should that be combined with this or do people prefer separate issues?

@diracdeltas diracdeltas modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Sep 29, 2018
@riastradh-brave riastradh-brave self-assigned this Oct 3, 2018
@bbondy bbondy added the QA/Yes label Oct 10, 2018
@yrliou yrliou self-assigned this Oct 12, 2018
@yrliou yrliou mentioned this issue Oct 12, 2018
Merged
18 tasks
@yrliou
Copy link
Member

yrliou commented Oct 14, 2018

The test plan in the description is for browser-laptop.
Please see the test plan specified in brave/brave-core#624.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 15, 2018 •
edited by btlechowski
Loading

Verified passed with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

@riastradh-brave riastradh-brave

Labels
browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor plugin/flash QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Disable flash in Tor brave/brave-core
8 participants
@diracdeltas @bbondy @yrliou @bsclifton @srirambv @LaurenWags @riastradh-brave @btlechowski