Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Ad conversions fail for pages which use pushState #11012

Closed
tmancey opened this issue Jul 30, 2020 · 2 comments · Fixed by brave/brave-core#6298
Closed

[Desktop] Ad conversions fail for pages which use pushState #11012

tmancey opened this issue Jul 30, 2020 · 2 comments · Fixed by brave/brave-core#6298
Assignees
@tmancey
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.13.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 30, 2020

Description

[Desktop] Ad conversions fail for pages which use pushState

Steps to Reproduce

  1. View ad with landing page which uses pushState (please DM for details)
  2. Visit conversion page

Actual result:

Failed to convert ad

Expected result:

Ad should convert

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/ads OS/Desktop labels Jul 30, 2020
@tmancey tmancey mentioned this issue Jul 31, 2020
Merged
32 tasks
@tmancey tmancey self-assigned this Jul 31, 2020
This was referenced Jul 31, 2020
Closed
Closed
@tmancey tmancey added this to the 1.14.x - Nightly milestone Aug 4, 2020
@tmancey tmancey added the OS/Android Fixes related to Android browser functionality label Aug 4, 2020
@tmancey tmancey mentioned this issue Aug 5, 2020
Merged
4 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Aug 26, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave	1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision	94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test cases from brave/brave-core#6298 (comment)

Case 1
Visited https://brave.com and ensured that the page was being classified as per the following:

[9406:775:0826/110928.358619:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[9406:775:0826/110928.359005:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[9406:775:0826/110928.455384:VERBOSE3:client.cc(525)] Saving client state
[9406:775:0826/110928.455623:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

Visited https://www.metacritic.com and ensured that the page was being classified as per the following:

[9406:775:0826/111159.221870:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[9406:775:0826/111159.222452:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[9406:775:0826/111159.332597:VERBOSE3:client.cc(525)] Saving client state
[9406:775:0826/111159.333068:VERBOSE1:ads_impl.cc(805)] Classified page as arts & entertainment-film. Winning page classification over time is technology & computing-software

Visited the site that @tmancey mentioned and clicked on Sign up and ensured that the page was being classified as per the following:

[9406:775:0826/111429.491758:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[9406:775:0826/111429.492013:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[9406:775:0826/111429.536071:VERBOSE3:client.cc(525)] Saving client state
[9406:775:0826/111429.536539:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing

Signed up and ensured the page was being classified as per the following:

[9406:775:0826/111539.478988:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[9406:775:0826/111539.479366:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[9406:775:0826/111539.527394:VERBOSE3:client.cc(525)] Saving client state
[9406:775:0826/111539.528367:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is technology & computing-technology & computing

Case 2:

Created a catalog.json with the conversion links that @tmancey provided. Once I received the ad and clicked on Sign up, ensured that the ad conversion process started as per the following:

[9922:775:0826/120719.755374:VERBOSE3:ad_conversions.cc(306)] Saving ad conversions state
[9922:775:0826/120719.755610:VERBOSE1:ad_conversions.cc(298)] Started ad conversion timer for creative instance id 0ae3c486-13f2-4ec7-9376-5578d7b0dcd8 and creative set id 32439113-32d2-4b50-9497-405b7eedd1d5 which will trigger in 0 hours, 4 minutes, 30 seconds at 12:11 PM
[9922:775:0826/120719.768365:VERBOSE3:client.cc(540)] Successfully saved client state
[9922:775:0826/120719.775416:VERBOSE3:ad_conversions.cc(319)] Successfully saved ad conversions state
[9922:775:0826/120721.034238:VERBOSE1:ads_impl.cc(774)] Visited URL matches the last shown ad notification
[9922:775:0826/120721.034344:VERBOSE1:ads_impl.cc(1437)] Already sustaining ad for visited URL
[9922:775:0826/120721.035987:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[9922:775:0826/120721.066053:VERBOSE3:client.cc(525)] Saving client state
[9922:775:0826/120721.066186:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing

Using --brave-ads-debug flag, ensured that the ad was converted as per the following:

[9922:775:0826/121149.757407:VERBOSE1:ad_conversions.cc(258)] Successfully converted ad with creative instance id 0ae3c486-13f2-4ec7-9376-5578d7b0dcd8 and creative set id 32439113-32d2-4b50-9497-405b7eedd1d5 in 0 hours, 0 minutes, 0 seconds at 12:11 PM
[9922:775:0826/121149.757648:VERBOSE3:ads_impl.cc(1487)] Event log: {"data":{"type":"confirmation","timestamp":"0 hours, 0 minutes, 0 seconds at 12:11 PM","creativeInstanceId":"0ae3c486-13f2-4ec7-9376-5578d7b0dcd8","confirmationType":"conversion"}}
[9922:775:0826/121149.757797:VERBOSE3:ad_conversions.cc(306)] Saving ad conversions state
[9922:775:0826/121149.757892:VERBOSE1:ad_conversions.cc(83)] Ad conversion queue is empty
[9922:775:0826/121149.758078:VERBOSE1:confirmations_impl.cc(1181)] Confirm action:
  creativeInstanceId: 0ae3c486-13f2-4ec7-9376-5578d7b0dcd8
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  confirmationType: conversion

[9922:775:0826/121150.549348:VERBOSE1:confirmations_impl.cc(1229)] Successfully redeemed unblinded token with confirmation id c88fb05c-d1c7-4163-b60f-dd780d9396c0, creative instance id 0ae3c486-13f2-4ec7-9376-5578d7b0dcd8 and conversion

Verification passed on

Brave 1.13.80 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Verified test cases from brave/brave-core#6298 (comment)

Case 1
Visited https://brave.com and ensured that the page was being classified as per the following:

[7393:7393:0827/060518.442584:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software
[7393:7393:0827/060518.443231:VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 6:05 AM","tabId":0,"tabType":"click","tabClassification":["technology & computing","software"]}}

Visited https://www.metacritic.com and ensured that the page was being classified as per the following:

[7393:7393:0827/060637.205148:VERBOSE1:ads_impl.cc(805)] Classified page as arts & entertainment-film. Winning page classification over time is personal finance-personal finance
[7393:7393:0827/060637.205172:VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 6:06 AM","tabId":3,"tabType":"click","tabClassification":["arts & entertainment","film"]}}

Visited the site that @tmancey mentioned and clicked on Sign up and ensured that the page was being classified as per the following:

[7393:7393:0827/060733.524578:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is arts & entertainment-literature

Signed up and ensured the page was being classified as per the following:

[7928:7928:0827/061026.832240:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is technology & computing-technology & computing
[7928:7928:0827/061026.835645:VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 6:10 AM","tabId":11,"tabType":"click","tabClassification":["personal finance","investing"]}}

Created a catalog.json with the conversion links that @tmancey provided. Once I received the ad and clicked on Sign up, ensured that the ad conversion process started as per the following:

[11507:11507:0827/063951.608341:VERBOSE1:ad_conversions.cc(134)] Ad conversion for creative set id c7f96341-726f-4e5d-9494-5686db89664b and postview
[11507:11507:0827/063951.610837:VERBOSE1:ad_conversions.cc(298)] Started ad conversion timer for creative instance id 7e798d96-3ab9-4469-862d-f04d3d8b9506 and creative set id c7f96341-726f-4e5d-9494-5686db89664b which will trigger in 0 hours, 10 minutes, 9 seconds at 6:50 AM

Converted the ad:

[11507:11507:0827/065002.257786:VERBOSE1:confirmations_impl.cc(1229)] Successfully redeemed unblinded token with confirmation id 0b6f85b4-24f1-4bbb-ad79-78184e746d5f, creative instance id 7e798d96-3ab9-4469-862d-f04d3d8b9506 and conversion

Verification is in progress


Brave | 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Case 1
Visited https://brave.com and ensured that the page was being classified as per the following:

[15712:17824:0827/121110.445:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[15712:17824:0827/121110.445:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[15712:17824:0827/121110.484:VERBOSE3:client.cc(525)] Saving client state
[15712:17824:0827/121110.484:VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software

Visited https://www.metacritic.com and ensured that the page was being classified as per the following:

[14288:12924:0827/122338.725:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[14288:12924:0827/122338.726:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[14288:12924:0827/122338.765:VERBOSE3:client.cc(525)] Saving client state
[14288:12924:0827/122338.765:VERBOSE1:ads_impl.cc(805)] Classified page as arts & entertainment-film. Winning page classification over time is arts & entertainment-film

Visited the site that @tmancey mentioned and clicked on Sign up and ensured that the page was being classified as per the following:

[16220:19028:0827/122754.994:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[16220:19028:0827/122754.994:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[16220:19028:0827/122755.013:VERBOSE3:client.cc(525)] Saving client state
[16220:19028:0827/122755.013:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing

Signed up and ensured the page was being classified as per the following:

[14820:4356:0827/123220.915:VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
[14820:4356:0827/123220.915:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[14820:4356:0827/123220.930:VERBOSE3:client.cc(525)] Saving client state
[14820:4356:0827/123220.930:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing

Created a catalog.json with the conversion links that @tmancey provided. Once I received the ad and clicked on Sign up, ensured that the ad conversion process started as per the following:

[21588:10328:0827/180727.436:VERBOSE1:ad_conversions.cc(134)] Ad conversion for creative set id 0aa3505d-9829-4c34-911a-7e0ecb691483 and postview
[21588:10328:0827/180727.436:VERBOSE3:client.cc(525)] Saving client state
[21588:10328:0827/180727.436:VERBOSE3:ad_conversions.cc(306)] Saving ad conversions state
[21588:10328:0827/180727.436:VERBOSE1:ad_conversions.cc(298)] Started ad conversion timer for creative instance id 6a66e391-9a1d-4349-8a04-64751edf692b and creative set id 0aa3505d-9829-4c34-911a-7e0ecb691483 which will trigger on Saturday, August 29, 2020 at 6:09:01 AM
[21588:10328:0827/180727.442:VERBOSE3:client.cc(540)] Successfully saved client state
[21588:10328:0827/180727.447:VERBOSE3:ad_conversions.cc(319)] Successfully saved ad conversions state
[21588:10328:0827/180729.096:VERBOSE1:ads_impl.cc(774)] Visited URL matches the last shown ad notification
[21588:10328:0827/180729.096:VERBOSE1:ads_impl.cc(1437)] Already sustaining ad for visited URL
[21588:10328:0827/180729.096:VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
[21588:10328:0827/180729.111:VERBOSE3:client.cc(525)] Saving client state
[21588:10328:0827/180729.112:VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing

[3204:17808:0830/181214.218:VERBOSE1:confirmations_impl.cc(1229)] Successfully redeemed unblinded token with confirmation id e3008208-1895-4e8d-ac84-d677b427d380, creative instance id 6a66e391-9a1d-4349-8a04-64751edf692b and conversion

@LaurenWags LaurenWags mentioned this issue Aug 26, 2020
Closed
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

  • Visited https://brave.com and ensured that the page was being classified as following:
2020-08-28 08:53:52.609 17012-17012/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 08:53:52.610 17012-17012/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 08:53:52.734 17012-17012/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 08:53:52.735 17012-17012/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is technology & computing-software
  • Visited https://www.metacritic.com and ensured that the page was being classified as per the following:
2020-08-28 09:13:52.609 17012-17012/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 09:13:52.610 17012-17012/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 09:13:52.734 17012-17012/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 09:13:52.735 17012-17012/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as tarts & entertainment-television. Winning page classification over time is arts & entertainment-television.

2020-08-28 09:46:03.117 22027-22027/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 09:46:03.118 22027-22027/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 09:46:03.199 22027-22027/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 09:46:03.200 22027-22027/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing
2020-08-28 09:46:03.200 22027-22027/? V/chromium: [VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 2:16 PM","tabId":2,"tabType":"click","tabClassification":["personal finance","investing"]}}
  • Visited the site that @tmancey mentioned and clicked on Sign up and ensured that the page was being classified as following
2020-08-28 09:42:24.032 17012-17012/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 09:42:24.033 17012-17012/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 09:42:24.104 17012-17012/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 09:42:24.106 17012-17012/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-personal finance
2020-08-28 09:42:24.106 17012-17012/? V/chromium: [VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 2:12 PM","tabId":8,"tabType":"click","tabClassification":["personal finance","investing"]}}

Verification passed on Samsung Tab A with Android 10 running 1.13.81 x64 build

  • Visited https://brave.com and ensured that the page was being classified as following:
2020-08-28 10:48:41.145 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 10:48:41.145 24867-24867/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 10:48:41.290 24867-24867/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 10:48:41.291 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as technology & computing-software. Winning page classification over time is science-biology
2020-08-28 10:48:41.291 24867-24867/? V/chromium: [VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 3:18 PM","tabId":5,"tabType":"click","tabClassification":["technology & computing","software"]
  • Visited https://www.metacritic.com and ensured that the page was being classified as per the following:
2020-08-28 10:49:20.584 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 10:49:20.585 24867-24867/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 10:49:20.717 24867-24867/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 10:49:20.718 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as arts & entertainment-television. Winning page classification over time is personal finance-personal finance
2020-08-28 10:49:20.719 24867-24867/? V/chromium: [VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 3:19 PM","tabId":6,"tabType":"click","tabClassification":["arts & entertainment","television"],
  • Visited the site that @tmancey mentioned and clicked on Sign up and ensured that the page was being classified as following

2020-08-28 10:46:15.677 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 10:46:15.678 24867-24867/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 10:46:15.758 24867-24867/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 10:46:15.759 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as personal finance-investing. Winning page classification over time is personal finance-investing
2020-08-28 10:46:15.760 24867-24867/? V/chromium: [VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 3:16 PM","tabId":4,"tabType":"click","tabClassification":["personal finance","investing"]}}
  • Signed up and ensured the page was being classified as following
2020-08-28 10:46:54.408 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(770)] Visited URL does not match the last shown ad notification
2020-08-28 10:46:54.410 24867-24867/? V/chromium: [VERBOSE1:ad_conversions.cc(68)] Checking URL for ad conversion
2020-08-28 10:46:54.507 24867-24867/? V/chromium: [VERBOSE3:client.cc(525)] Saving client state
2020-08-28 10:46:54.508 24867-24867/? V/chromium: [VERBOSE1:ads_impl.cc(805)] Classified page as science-biology. Winning page classification over time is science-biology
2020-08-28 10:46:54.509 24867-24867/? V/chromium: [VERBOSE3:ads_impl.cc(818)] Event log: {"data":{"type":"load","timestamp":"0 hours, 0 minutes, 0 seconds at 3:16 PM","tabId":4,"tabType":"click","tabClassification":["science","biology"],"
  • Confirmed with @tmancey that only case1 is sufficient for Android testing

This was referenced Sep 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixed ad conversions fail for pages which use pushState brave/brave-core
6 participants
@tmancey @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya