Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add support for #enable-force-dark #11085

Closed
anthonypkeane opened this issue Aug 4, 2020 · 3 comments · Fixed by brave/brave-core#6514
Closed

[Android] Add support for #enable-force-dark #11085

anthonypkeane opened this issue Aug 4, 2020 · 3 comments · Fixed by brave/brave-core#6514
Assignees
@SergeyZhukovsky
Labels
feature/settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.15.x - Release #1

Comments

@anthonypkeane
Copy link

Description

See: https://bravesoftware.slack.com/archives/C0816QH3R/p1596571834338300

Enable support for #enable-force-dark

Add a setting in Settings > Display > Appearance
As the top menu item add

Enable "Night Mode"

Exact label text TBD
@anthonypkeane anthonypkeane added QA/Yes OS/Android Fixes related to Android browser functionality labels Aug 4, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 5, 2020

Enable "Night Mode" should be Enable "Night Mode" (Experimental)

@SergeyZhukovsky SergeyZhukovsky self-assigned this Aug 25, 2020
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Aug 26, 2020
Merged
32 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.15.x - Nightly milestone Aug 27, 2020
@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2020 •
edited
Loading

Verification passed on OnePlus 6T with Android 10 running 1.15.54 x64 beta build

  • Verified new settings option Enable "Night Mode"(Experimental) is listed under Settings -> Appearance
  • Verified enabling/disabling the settings prompts for a relaunch
  • Veriifed selecting later in relaunch prompt doesn't cause the webview to either go dark or remain white until browser is restarted
  • Verified enabling the settings enables the flag chrome://flags#enable-force-dark
  • Verified enabling the settings causes webview to be dark mode
Setting Restart alert Flag Dark webview
image image image image

Logged followup issue for missing translation #11781

Tablet test blocked on #11783

Verification passed on Samsung Tab A with Android 10 running 1.15.54 x64 beta build

  • Verified new settings option Enable "Night Mode"(Experimental) is listed under Settings -> Appearance
  • Verified enabling/disabling the settings prompts for a relaunch
  • Verified selecting later in relaunch prompt doesn't cause the webview to either go dark or remain white until the browser is restarted
  • Verified enabling the settings enables the flag chrome://flags#enable-force-dark
  • Verified enabling the settings causes webview to be dark mode
Setting Restart alert Flag Dark webview
image image image image

This was referenced Sep 22, 2020
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Sep 25, 2020
Closed
@Dev-i-l
Copy link

Dev-i-l commented Sep 26, 2020 •
edited
Loading

PLEASE MAKE SURE THAT DARK MODE IS ACCESSIBLE THROUGH 3-DOT MENU.

@kjozwiak kjozwiak mentioned this issue Oct 8, 2020
Closed
@hennrynusasatria hennrynusasatria mentioned this issue Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

adds enable web content dark mode on android option brave/brave-core
4 participants
@anthonypkeane @SergeyZhukovsky @srirambv @Dev-i-l