Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions #11218

Closed
tmancey opened this issue Aug 13, 2020 · 2 comments · Fixed by brave/brave-core#6608

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 13, 2020

We have Tor regular and Tor incognito profiles created when using Tor window, the regular one will return false for Profile::IsOffTheRecord. Some of our services currently only checks Profile::IsOffTheRecord where it will miss Tor regular profile, and guest profile's parent profile (they also seem to create a pair as we do for Tor).
This issue is to add a brave's own IsRegularProfile to exclude otr, Tor profiles, and guest sessions.

@tmancey tmancey self-assigned this Aug 13, 2020
@tmancey tmancey changed the title IsOffTheRecord profiles do not return true for Tor profiles Profile::IsOffTheRecord returns false for Tor profiles Aug 13, 2020
@tmancey tmancey removed their assignment Aug 13, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Aug 13, 2020

@fmarier FYI

@yrliou
Copy link
Member

yrliou commented Aug 14, 2020

When creating Tor window, we have a pair of profile being created, one regular dummy profile and one incognito one which is used for actual browsing. It is expected that one would return true for Profile::IsOffTheRecord and the other one would return false for Profile::IsOffTheRecord.
Plan here is to add brave::IsRegularProfile for our own services to use which will return !brave::IsTorProfile && profile::IsRegularProfile.

@srirambv srirambv changed the title Profile::IsOffTheRecord returns false for Tor profiles [Desktop] Profile::IsOffTheRecord returns false for Tor profiles Sep 9, 2020
@yrliou yrliou changed the title [Desktop] Profile::IsOffTheRecord returns false for Tor profiles [Desktop] Add a util function to cover both Profile::IsOffTheRecord and Tor profiles Sep 9, 2020
@yrliou yrliou changed the title [Desktop] Add a util function to cover both Profile::IsOffTheRecord and Tor profiles [Desktop] Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions Sep 9, 2020
@yrliou yrliou added this to the 1.16.x - Nightly milestone Sep 10, 2020
@rebron rebron changed the title [Desktop] Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment