You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have Tor regular and Tor incognito profiles created when using Tor window, the regular one will return false for Profile::IsOffTheRecord. Some of our services currently only checks Profile::IsOffTheRecord where it will miss Tor regular profile, and guest profile's parent profile (they also seem to create a pair as we do for Tor).
This issue is to add a brave's own IsRegularProfile to exclude otr, Tor profiles, and guest sessions.
The text was updated successfully, but these errors were encountered:
tmancey
changed the title
IsOffTheRecord profiles do not return true for Tor profiles
Profile::IsOffTheRecord returns false for Tor profiles
Aug 13, 2020
When creating Tor window, we have a pair of profile being created, one regular dummy profile and one incognito one which is used for actual browsing. It is expected that one would return true for Profile::IsOffTheRecord and the other one would return false for Profile::IsOffTheRecord.
Plan here is to add brave::IsRegularProfile for our own services to use which will return !brave::IsTorProfile && profile::IsRegularProfile.
srirambv
changed the title
Profile::IsOffTheRecord returns false for Tor profiles
[Desktop] Profile::IsOffTheRecord returns false for Tor profiles
Sep 9, 2020
yrliou
changed the title
[Desktop] Profile::IsOffTheRecord returns false for Tor profiles
[Desktop] Add a util function to cover both Profile::IsOffTheRecord and Tor profiles
Sep 9, 2020
yrliou
changed the title
[Desktop] Add a util function to cover both Profile::IsOffTheRecord and Tor profiles
[Desktop] Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions
Sep 9, 2020
rebron
changed the title
[Desktop] Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions
Add a util function to cover Profile::IsOffTheRecord, Tor profiles, and guest sessions
Oct 26, 2020
We have Tor regular and Tor incognito profiles created when using Tor window, the regular one will return false for
Profile::IsOffTheRecord
. Some of our services currently only checksProfile::IsOffTheRecord
where it will miss Tor regular profile, and guest profile's parent profile (they also seem to create a pair as we do for Tor).This issue is to add a brave's own IsRegularProfile to exclude otr, Tor profiles, and guest sessions.
The text was updated successfully, but these errors were encountered: