Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop][CW][Follow up to #11483]Gemini entry in new tab page settings is not removed for unsupported region #11649

Closed
srirambv opened this issue Sep 10, 2020 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

[Follow up to #11483]Gemini entry in newtab page settings is not removed for unsupported region

Steps to Reproduce

  1. Clean install 1.13.86 for French region
  2. Open a new tab no Gemini widget is found
  3. Open Settings -> New Tab page -> Gemini switch is still available

Actual result:

Linux

French German
Screenshot 2020-09-10 at 8 33 59 a m Screenshot 2020-09-10 at 8 37 22 a m

Windows

French German
Screenshot 2020-09-10 at 8 42 32 a m Screenshot 2020-09-10 at 8 49 42 a m

Expected result:

Gemini option should not be in NTP settings when widget isn't available

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-Bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Linux
Brave 1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-Bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Windows 10 OS Version 1809 (Build 17763.1397)

Version/Channel Information:

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@GeetaSarvadnya
Copy link

Reproduced in windows for unsupported region India. Although the Gemini widget is not shown in NTP but in new tab settings the option is still available/enabled

image

@srirambv
Copy link
Contributor Author

@rebron this is an issue only on 13.x branch. Its not an issue on 1.14.x branch. Are we ok to close this out or should it be fixed for 13.x branch as well?
image

@ryanml
Copy link
Contributor

ryanml commented Sep 14, 2020

Keeping out of 1.13.x cc: @rebron @srirambv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@ryanml @srirambv @GeetaSarvadnya and others