Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CNAME adblocking #11712

Closed
antonok-edm opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6640
Closed

Support CNAME adblocking #11712

antonok-edm opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6640

Comments

@antonok-edm
Copy link
Collaborator

The API described in #7117 is primarily used by extensions to block resources that served from many different domains to circumvent traditional adblocking techniques. Similarly, Brave's most important use-case for the DNS resolution API is to integrate it with Shields.

Shields should block any network requests where either the original URL or that URL's canonical name (DNS CNAME record) matches any adblock rules.

Since our network blocking is done in C++ code, this doesn't necessarily need to be exposed as a Javascript API.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 9, 2020

Verified passed with

Brave | 1.17.63 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified test plan from brave/brave-core#6640. Confirmed https://xxxx.mathon.fr/xxxxxxxxxxx.js listed in shields with above build. Confirmed https://static.criteo.net/js/ld/ld.js is not listed in shields on Network tab of Dev Tools.

Screenshots Screen Shot 2020-11-09 at 7 08 43 AM Screen Shot 2020-11-09 at 7 10 20 AM

Verified passed with

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from brave/brave-core#6640. Confirmed https://xxxx.mathon.fr/xxxxxxxxxxx.js listed in shields with above build. Confirmed https://static.criteo.net/js/ld/ld.js is not listed in shields on Network tab of Dev Tools.

Screenshots

image
image


Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6640. Confirmed https://xxxx.mathon.fr/xxxxxxxxxxx.js listed in shields with above build. Confirmed https://static.criteo.net/js/ld/ld.js is not listed in shields on Network tab of Dev Tools.

Screenshots ![image](https://user-images.githubusercontent.com/34715963/98609773-66f7aa80-22ee-11eb-9ff6-0821f5e5329e.png) ![image](https://user-images.githubusercontent.com/34715963/98609784-6c54f500-22ee-11eb-9832-65e18a911c92.png)

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.17.66 x64 beta build

  • Verified https://xxxx.mathon.fr/xxxxxxxx.js is blocked
  • Verified https://static.criteo.net/js/ld/ld.js is not listed
    image

Verification passed on Samsung Tab A with Android 10 running 1.17.66 x64 beta build

  • Verified https://xxxx.mathon.fr/xxxxxxxx.js is blocked
  • Verified https://static.criteo.net/js/ld/ld.js is not listed
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants