Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint setting changes are not retained #11786

Closed
srirambv opened this issue Sep 21, 2020 · 4 comments · Fixed by brave/brave-core#6702
Closed

Fingerprint setting changes are not retained #11786

srirambv opened this issue Sep 21, 2020 · 4 comments · Fixed by brave/brave-core#6702
Assignees
@deeppandya
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include
Milestone
1.15.x - Release #1

Comments

@srirambv
Copy link
Contributor

Description

Fingerprint setting changes are not retained

Steps to reproduce

  1. Install 1.16.28 nightly build or 1.15.54 beta build
  2. Visit any page and opens shields
  3. Set FP to Block all fingerprinting and click done
  4. Wait for the page to reload and check the setting, changes are retained
  5. Change FP to Block third party fingerprinting and click done
  6. Wait for the page to reload and check the setting, resets to Block all fingerprinting
  7. Change FP to Allow all fingerprinting and click done
  8. Wait for the page to reload and checking the setting, retains Allow all fingerprinting

Actual result

android-shields

Expected result

Should retain the shields settings change

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):Phone
  • Android version: 10

Brave version

1.11.105 onwards

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc: @SergeyZhukovsky @anthonypkeane @deeppandya we should probably fix this one and get it uplifted.
@srirambv srirambv added feature/shields The overall Shields feature in Brave. priority/P2 A bad problem. We might uplift this to the next planned release. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes release-notes/include regression OS/Android Fixes related to Android browser functionality labels Sep 21, 2020
@deeppandya
Copy link

This may be because of cosmetic filtering. @srirambv Is this a regression ?

@srirambv
Copy link
Contributor Author

Not really. The issue is happening from 1.11.x where the simple shields went in. So something to do with the that

@diracdeltas
Copy link
Member

we've also seen a similar report on desktop: #10790

@deeppandya deeppandya self-assigned this Sep 22, 2020
@deeppandya deeppandya mentioned this issue Sep 25, 2020
Merged
32 tasks
@brave-builds brave-builds mentioned this issue Sep 25, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2020

Verification passed on Samsung Tab A with Android 10 running 1.15.69 x64 build

  • Verified test plan from issue description

Verification passed on OnePlus 6T with Android 10 running 1.15.69 x64 build

  • Verified test plan from issue description

@kjozwiak kjozwiak mentioned this issue Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fix shields for fingerprinting v2 android brave/brave-core
4 participants
@diracdeltas @kjozwiak @deeppandya @srirambv