Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] window size affects error message display in Rewards #11908

Closed
LaurenWags opened this issue Sep 29, 2020 · 2 comments
Closed

[Desktop] window size affects error message display in Rewards #11908

LaurenWags opened this issue Sep 29, 2020 · 2 comments
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 29, 2020

Description

Certain window sizes cause a problem displaying the "error" notification when trying to use Uphold rewards in a region without support (ex. NY). From what I've observed, in this case the error flashes on screen but doesn't persist. This then puts the user into a bad state because they haven't been given the error, so they have no information. If they click on "Verify Wallet" nothing happens on screen - basically it appears as though the integration is broken.

Note - in the terminal logs you do see this when clicking on Verify Wallet

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me
> Method: UrlMethod::GET
[15114:775:0929/074839.490957:INFO:uphold_wallet.cc(89)] BAT not allowed

Steps to Reproduce

  1. Clean profile, staging, enable Rewards. Note your window size.
  2. Claim UGP grant.
  3. Click on Verify Wallet.
  4. Login with credentials for an NY account.
  5. You will be redirected back to brave://rewards page

Actual result:

when window size is 1013px tall and 1200px wide (my default window size) the error message flashes and goes away quickly. Note how clicking on Verify Wallet doesn't do anything from brave://rewards and clicking on this from the panel opens a blank new tab. User is in a bad state at this point. (gif picks up at step 4 from above)
NY1200x1013

it's tough to see in the above gif, but here's a slightly different window size where you can see the flash of the error a bit better:
ny-again2

Expected result:

If I size the window down (to 699px tall by 928 px wide), no issues with error message displaying:
ny-again3

Reproduces how often:

easily depending on window size

Brave version (brave://version info)

Brave 1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit)
Revision a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
OS macOS Version 10.14.6 (Build 18G3020)
Brave 1.15.65 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes, 1.14.x
  • Can you reproduce this issue with the beta channel? yes, 1.15.x
  • Can you reproduce this issue with the nightly channel? yes, 1.16.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @brave/legacy_qa @rebron

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 3, 2022

Has this been resolved since Rewards 2.0?

@LaurenWags
Copy link
Member Author

Did not reproduce with specified window size.

@LaurenWags LaurenWags added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed bug feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes OS/Desktop labels Aug 10, 2022
@LaurenWags LaurenWags closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

3 participants