Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show explicit log message when ads are capped due to user activity #11923

Closed
btlechowski opened this issue Sep 30, 2020 · 1 comment
Closed

Comments

@btlechowski
Copy link

In brave/brave-core#6703 user activity frequency capping was implemented.
However a generic log message is shown when ad is capped. It is hard for QA to debug what happens.

Steps to Reproduce

  1. Clean profile on staging
  2. Enable rewards
  3. Wait till ads are initialized
  4. Trigger an ad

Actual result:

A generic ad message is shown in the logs
[ads_impl.cc(876)] Ad notification not shown: Not allowed based on history

Expected result:

An explicit message, for example:
Ad notification not shown due to user activity frequency capping

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey

@tmancey
Copy link
Contributor

tmancey commented Sep 30, 2020

Closing issue as wont fix. Discussed in DM.

@tmancey tmancey closed this as completed Sep 30, 2020
@tmancey tmancey self-assigned this Sep 30, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants