Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop mode can't be disabled on nightly #11928

Closed
srirambv opened this issue Sep 30, 2020 · 1 comment · Fixed by brave/brave-core#6984
Closed

Desktop mode can't be disabled on nightly #11928

srirambv opened this issue Sep 30, 2020 · 1 comment · Fixed by brave/brave-core#6984

Comments

@srirambv
Copy link
Contributor

Description

Desktop mode can't be disabled on nightly

Steps to reproduce

  1. Install 1.17.1 on tablet
  2. Open a page and open menu, desktop mode is enabled
  3. Try to uncheck the setting, doesn't work
  4. Go to site settings, desktop mode is disabled (default value)

Actual result

https://youtu.be/xZo1coXT1RI

Expected result

Should not enable desktop mode by default and should be able to disable it if enabled manually

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 10

Brave version

1.17.1

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Note: On mobile, clicking Desktop mode doesn't select the option but page reloads to desktop mode. Clicking the option again doesn't revert back to mobile view

@srirambv
Copy link
Contributor Author

srirambv commented Oct 30, 2020

Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build

  • Verified desktop mode is not enabled by default
  • Verified visiting a mobile page and selecting desktop stie from menu loads the page in desktop mode
  • Verified toggle desktop site on a desktop page reloads and loads mobile page

Verification passed on OnePlus 6T with Android 10 running 1.16.69 x64 build

  • Verified desktop mode is not enabled by default
  • Verified visiting a mobile page and selecting desktop stie from menu loads the page in desktop mode
  • Verified toggle desktop site on a desktop page reloads and loads mobile page

Verification passed on Samsung Galaxy j3 version 5.1.1 running Bravearm 1.16.69.apk

  • Verified desktop mode is not enabled by default
  • Verified visiting a mobile page and selecting desktop stie from menu loads the page in desktop mode
  • Verified toggle desktop site on a desktop page reloads and loads mobile page

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.16.69 Bravex86.apk

  • Verified desktop mode is not enabled by default
  • Verified visiting a mobile page and selecting desktop site from menu loads the page in desktop mode
  • Verified toggle desktop site on a desktop page reloads and loads mobile page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants