[Desktop] Greaselion doesn't respect twitter-tips-enabled precondition - follow up to #11664

[LaurenWags]

Per internal discussions (https://bravesoftware.slack.com/archives/CB0KCRCQN/p1601901591057200), #11664 should be tested when Twitter tipping with Greaselion lands which is expected to be with 1.17.x.

Per process, logging this follow up issue so the issue can be tested in 1.17x.

Below is the original issue description:

Description

Greaselion doesn't respect the twitter-tips-enabled precondition.

Steps to Reproduce

Create a Greaselion.json file like this:

[
  {
    "urls": [
      "https://twitter.com/*",
      "https://*.twitter.com/*"
    ],
    "scripts": [
      "scripts/brave_rewards/publisher/twitter/twitter.bundle.js"
    ],
    "preconditions": {
      "twitter-tips-enabled": true
    }
  }
]

1. Launch browser with a clean profile
2. Enable Rewards
3. Disable Twitter tipping in Rewards settings
4. Relaunch browser
5. Visit site that matches Greaselion rule with precondition

Actual result:

Greaselion script runs even though Twitter tips is disabled.

Expected result:

Greaselion script shouldn't run, since twitter-tips-enabled precondition hasn't been satisfied.

Reproduces how often:

Every time

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[LaurenWags]

Verified passed with

Brave | 1.17.28 Chromium: 86.0.4240.75 (Official Build) nightly (x86_64)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description.
Encountered and logged #12090.

---

Verification passed on

Brave	1.15.75 Chromium: 86.0.4240.99 (Official Build) (64-bit)
Revision	002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS	Ubuntu 18.04 LTS

Verified STR from description.

---

Verification passed on

Brave | 1.17.55 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

Verified STR from description.