Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Educational in-product notification #12209

Closed
chkk525 opened this issue Oct 20, 2020 · 1 comment · Fixed by brave/brave-core#7715
Closed

Educational in-product notification #12209

chkk525 opened this issue Oct 20, 2020 · 1 comment · Fixed by brave/brave-core#7715
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@chkk525
Copy link

chkk525 commented Oct 20, 2020

Description

Please search for the spec "Educational in-product notification" for details

The issue for iOS: brave/brave-ios#2980

Designs

image

Assets

Figma: https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/?node-id=1384%3A0

Q/A

  1. we have already released first pink orange tooltip. so in that case, should we reset the preference for the existing user or we shouldn't show it for existing user ? Answer : we shouldn't show it.
  2. Should we show the tooltip if the shields panel is already opened ? Answer : We shouldn't show any tooltip if the shields panel is opened.
  3. What should happen if the tooltip is visible and user changes the orientation ? Answer : Since orientation change reloads the page and user has already seen the tooltip, we should close the tooltip.
  4. Should tooltip be closed on back button pressed ? Answer : Yes
  5. Should tooltip be closed by tapping outside of the tooltip area ? Answer : Yes

Notes

In case more than 1 condition is satisfied simultaneously, the notifications should be prioritised:

  1. pink orange initial intro tooltip
  2. Video ads blocked
  3. 10+ trackers & ads
  4. Connection encrypted
    We only show the tooltips one at a time. so during the same app open session, user should see only one tooltip. and user should see any of the tooltips only once.
@chkk525 chkk525 added the OS/Android Fixes related to Android browser functionality label Oct 20, 2020
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 20, 2020
@anthonypkeane anthonypkeane removed their assignment Oct 20, 2020
@deeppandya deeppandya self-assigned this Jan 27, 2021
@deeppandya deeppandya added this to the 1.21.x - Nightly milestone Jan 29, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2021

Verification passed on OnePlus 6T with Android 10 running 1.20.100 x64 build

  • Verified test plan from issue description
  • Verified only one tooltip is shown at a time even when multiple conditions are met
  • Verified tooltip is dismissed when orientation is changed
  • Verified tooltip is dismissed when tapped outside the notification area
  • Verified tooltip is dismissed when back button is pressed
Ads/Trackers blocked (Pink-orange) Video Ads blocked (Blue) 10+ Trackers blocked (Blue) Encrypted Connection (Blue)
image image image image

Verification passed on Samsung Tab A with Android 10 running 1.20.100 x64 build

  • Verified test plan from issue description
  • Verified only one tooltip is shown at a time even when multiple conditions are met
  • Verified tooltip is dismissed when orientation is changed
  • Verified tooltip is dismissed when tapped outside the notification area
  • Verified tooltip is dismissed when back button is pressed
Ads/Trackers blocked (Pink-orange) Video Ads blocked (Blue) 10+ Trackers blocked (Blue) Encrypted Connection (Blue)
image image image image

Verification passed on LG Nexus 5 with Android 5.1 running 1.20.102 Bravearm.apk

  • Verified test plan from issue description
  • Verified only one tooltip is shown at a time even when multiple conditions are met
  • Verified tooltip is dismissed when orientation is changed
  • Verified tooltip is dismissed when tapped outside the notification area
  • Verified tooltip is dismissed when back button is pressed
Ads/Trackers blocked (Pink-orange) Video Ads blocked (Blue) 10+ Trackers blocked (Blue) Encrypted Connection (Blue)
Screenshot_2021-02-09-11-26-11 Screenshot_2021-02-09-11-31-40 Screenshot_2021-02-09-11-31-10 Screenshot_2021-02-09-11-32-33

Verification passed on Samsung Galaxy with Android 5.1 running 1.20.102 Bravearm.apk

  • Verified test plan from issue description
  • Verified only one tooltip is shown at a time even when multiple conditions are met
  • Verified tooltip is dismissed when orientation is changed
  • Verified tooltip is dismissed when tapped outside the notification area
  • Verified tooltip is dismissed when back button is pressed
Ads/Trackers blocked (Pink-orange) Video Ads blocked (Blue) 10+ Trackers blocked (Blue) Encrypted Connection (Blue)
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants