Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in BraveContentSettingsAgentImpl #12268

Closed
iefremov opened this issue Oct 22, 2020 · 3 comments · Fixed by brave/brave-core#6938
Closed

Crash in BraveContentSettingsAgentImpl #12268

iefremov opened this issue Oct 22, 2020 · 3 comments · Fixed by brave/brave-core#6938
Assignees
Labels
crash/webview Only tab webview crash. Browser doesn't crash OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include

Comments

@iefremov
Copy link
Contributor

iefremov commented Oct 22, 2020

For QA: crash is reproduced by visiting https://www.dell.com/support/home/ru-ru/product-support/product/idrac9-lifecycle-controller-v4.x-series/docs and hard-reload (Cmd-Shift-R)

[ 00 ] <name omitted>
[ 01 ] <name omitted>
[ 02 ] content_settings::BraveContentSettingsAgentImpl::AllowScript(bool)
[ 03 ] blink::LocalDOMWindow::CanExecuteScripts(blink::ReasonForCallingCanExecuteScripts)
[ 04 ] blink::HTMLMediaElement::ShouldShowControls(blink::HTMLMediaElement::RecordMetricsBehavior) const
[ 05 ] blink::MediaControlsImpl::UpdateCSSClassFromState()
[ 06 ] blink::HTMLMediaElement::ContextDestroyed()
[ 07 ] blink::ExecutionContext::NotifyContextDestroyed()
[ 08 ] blink::LocalDOMWindow::FrameDestroyed()
[ 09 ] blink::LocalFrame::DetachImpl(blink::FrameDetachType)
[ 10 ] blink::Frame::Detach(blink::FrameDetachType)
[ 11 ] blink::Page::WillBeDestroyed()
[ 12 ] blink::WebViewImpl::Close()
[ 13 ] content::RenderViewImpl::Destroy()

https://brave.sp.backtrace.io/p/brave/debug?filters=(_deleted%3D0%2Cptype%3Drenderer%2C(ver%2Cregex%2C%228%5B5%7C6%7C7%7C8%7C9%5D.*%22))&fingerprint=22190b8f97b01300d5114c4977e24e6313ad884621a5da62411c4d3a8b211a56&debug=(b75f45,0,0)

@iefremov iefremov added crash/webview Only tab webview crash. Browser doesn't crash OS/Desktop labels Oct 22, 2020
@iefremov
Copy link
Contributor Author

also

[ 00 ] blink::SecurityOrigin::ToUrlOrigin() const
[ 01 ] blink::WebSecurityOrigin::operator url::Origin() const
[ 02 ] content_settings::BraveContentSettingsAgentImpl::AllowScript(bool)
[ 03 ] blink::LocalDOMWindow::CanExecuteScripts(blink::ReasonForCallingCanExecuteScripts)
[ 04 ] blink::HTMLMediaElement::ShouldShowControls(blink::HTMLMediaElement::RecordMetricsBehavior) const
[ 05 ] blink::MediaControlsImpl::UpdateCSSClassFromState()
[ 06 ] blink::HTMLMediaElement::ContextDestroyed()
[ 07 ] blink::ExecutionContext::NotifyContextDestroyed()
[ 08 ] blink::LocalDOMWindow::FrameDestroyed()
[ 09 ] blink::LocalFrame::DetachImpl(blink::FrameDetachType)
[ 10 ] blink::Frame::Detach(blink::FrameDetachType)
[ 11 ] blink::Page::WillBeDestroyed()
[ 12 ] blink::WebViewImpl::Close()
[ 13 ] content::RenderViewImpl::Destroy()

https://brave.sp.backtrace.io/p/brave/debug?filters=(_deleted%3D0%2Cptype%3Drenderer%2C(ver%2Cregex%2C%228%5B5%7C6%7C7%7C8%7C9%5D.*%22))&fingerprint=3e45066d2f1a26fcfe30ccf8832a984d0325e8d581977d3221711c165a32d591&debug=(b7686d,0,0)

and
https://brave.sp.backtrace.io/p/brave/debug?filters=(_deleted%3D0%2Cptype%3Drenderer%2C(ver%2Cregex%2C%228%5B5%7C6%7C7%7C8%7C9%5D.*%22))&fingerprint=c3e113fa2a98d80133890c11553f888bafce8ba4c70204363a1df910d0dcdf03

@kjozwiak
Copy link
Member

kjozwiak commented Nov 2, 2020

@iefremov added OS/Android as this is reproducible on Android using 1.16.68 CR: 86.0.4240.111

Screenshot_20201102-142531_Brave

@kjozwiak
Copy link
Member

kjozwiak commented Nov 2, 2020

Verification PASSED on Samsung S10+ running Android 10 using 1.16.70 CR: 86.0.4240.111

Reproduced the original issue using 1.16.68 CR: 86.0.4240.111

Verification PASSED on Samsung Galaxy Tablet A running Android 10 using 1.16.70 CR: 86.0.4240.111


Verification PASSED on Asus Zenfone (x86) running Android 6 using 1.16.70 CR: 86.0.4240.111

Reproduced the original issue using 1.16.68 CR: 86.0.4240.111


Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.16.71 Chromium: 86.0.4240.111 (Official Build) (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.15.7 (Build 19H2)

Verification passed on

Brave | 1.16.72 Chromium: 86.0.4240.183 (Official Build) (64-bit)
-- | --
Revision | 0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS | Windows 10 OS Version 1903 (Build 18362.1139)


Verification passed on

Brave 1.16.72 Chromium: 86.0.4240.183 (Official Build) (64-bit)
Revision 0b568b034b8f7994697cb341eeca5979b84151cc-refs/branch-heads/4240@{#1374}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash/webview Only tab webview crash. Browser doesn't crash OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants