Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top site setting isn't in sync between brave://settings/newTab and dashboard settings in NTP #12458

Closed
GeetaSarvadnya opened this issue Nov 2, 2020 · 2 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 2, 2020

Description

Top site setting isn't in sync between brave://settings/newTab and dashboard settings in NTP

Steps to Reproduce

STR1:

  1. Clean profile 1.18.x
  2. Open NTP Dashboard settings
  3. Looks for Topsites settings (Topsites settings is ENABLED)
  4. Open brave://settings/newTab
  5. Looks for Topsites settings (Topsites settings is DISABLED)

STR2:

  1. Clean profile 1.18.x
  2. Open brave://settings/newTab
  3. Looks for Topsites settings (By default settings is DISABLED)
  4. Enable Topsites settings and restart the browser
  5. Setting reverted back to disabled

Actual result:

image

Expected result:

All the settings in NTP and brave://settings/newTab should be in sync

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.18.27 Chromium: 87.0.4280.40 (Official Build) nightly (64-bit)
Revision 349b9adbfb2784db684617c7731a57d1e61b3be0-refs/branch-heads/4280@{#863}
OS Windows 10 OS Version 1903 (Build 18362.1139)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bsclifton @karenkliu

@rebron
Copy link
Collaborator

rebron commented Nov 4, 2020

Closing as wontfix in favor of #12505 which will have a pointer from Settings to the New Tab page so we don't have these redundancies and overhead.

@rebron
Copy link
Collaborator

rebron commented Nov 4, 2020

@GeetaSarvadnya Thanks for filing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants