Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable upgrade notification #12507

Closed
SergeyZhukovsky opened this issue Nov 3, 2020 · 1 comment · Fixed by brave/brave-core#7047
Closed

Disable upgrade notification #12507

SergeyZhukovsky opened this issue Nov 3, 2020 · 1 comment · Fixed by brave/brave-core#7047
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release/blocking release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

Description

Disable notification on upgrade. We have users who receive it still, probably it was never hit as we don't show it after tap on it.
Screenshot from 2020-11-03 16-06-19

Steps to reproduce

  1. Install a fresh installation of Brave.
  2. Update it to a newer version.

Actual result

See the above notification.

Expected result

No notification

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

kjozwiak commented Nov 10, 2020

Verification PASSED on Samsung S10+ on Android 10 using 1.16.75 CR: 86.0.4240.193


Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.16.75 Bravex86.apk

  • ensured that upgrading from 1.16.74 CR: 86.0.4240.185 to 1.16.75 CR: 86.0.4240.193 didn't display the Save Data Online notification.

Verification passed on Brave v1.16.75 on Samsung Galaxy Tab S5e (Android 9.0)

  • ensured that upgrading from 1.16.74 CR: 86.0.4240.185 to 1.16.75 CR: 86.0.4240.193 didn't display the Save Data Online notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release/blocking release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants