Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always block WebRTC in Tor #1254

Closed
btlechowski opened this issue Sep 24, 2018 · 2 comments · Fixed by brave/brave-core#545
Closed

Always block WebRTC in Tor #1254

btlechowski opened this issue Sep 24, 2018 · 2 comments · Fixed by brave/brave-core#545
Assignees
@yrliou
Labels
feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking
Milestone
0.55.x - Release ...

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Open https://diafygi.github.io/webrtc-ips/ in Tor Window

Actual result:

IPs are leaked

Expected result:

Always block webrtc in Tor, even if Brave shields are off.
Similar to browser laptop.

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Reproducible on current release:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

cc @darkdh @riastradh-brave
@btlechowski btlechowski added feature/tor feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. browser-laptop-parity labels Sep 24, 2018
@srirambv srirambv added this to the 1.0 milestone Sep 24, 2018
@bbondy
Copy link
Member

bbondy commented Sep 24, 2018 •
edited
Loading

Moving to 1.0

@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Sep 24, 2018
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed browser-laptop-parity labels Sep 28, 2018
@srirambv srirambv mentioned this issue Sep 29, 2018
Closed
@bbondy bbondy modified the milestones: 1.x Backlog, 1.0 (0.56.x) Sep 29, 2018
@diracdeltas diracdeltas modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Sep 29, 2018
@yrliou yrliou self-assigned this Sep 29, 2018
@yrliou yrliou mentioned this issue Oct 2, 2018
Merged
11 tasks
@yrliou yrliou added the QA/Yes label Oct 2, 2018
@LaurenWags LaurenWags mentioned this issue Oct 8, 2018
Open
@LaurenWags
Copy link
Member

LaurenWags commented Oct 8, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix WebRTC IP leak in Tor profile brave/brave-core
7 participants
@diracdeltas @bbondy @yrliou @rebron @srirambv @LaurenWags @btlechowski