Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need text change for Ad notifications received this month #12719

Closed
GeetaSarvadnya opened this issue Nov 16, 2020 · 1 comment · Fixed by brave/brave-core#7163
Closed

Need text change for Ad notifications received this month #12719

GeetaSarvadnya opened this issue Nov 16, 2020 · 1 comment · Fixed by brave/brave-core#7163

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 16, 2020

Description

The text Ad notifications received this month needs to be renamed to Ads received this month

As discussed with @tmancey For NTP SI we are not supposed to get Ad notification pop-ups in the browser as per the design, the text "notifications" may confuse the user hence this needs to be removed and rename the text to Ads received this month

Steps to Reproduce

NA

Actual result:

Need text change for Ad notifications received this month

Expected result:

Remove "notifications" from Ad notifications received this month

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 10 OS Version 1903 (Build 18362.1139)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @jsecretan @rebron

@kjozwiak
Copy link
Member

kjozwiak commented Nov 27, 2020

Verification PASSED on Samsung S10+ running Android 10 using 1.17.74 CR: 87.0.4280.67

  • ensured that Ads received this month is being used/displayed on a clean install
  • ensured that Ads received this month is being used after upgrading from 1.17.72 CR: 87.0.4280.66
Clean Install 1.17.72 CR: 87.0.4280.66 Updating to 1.17.74 CR: 87.0.4280.67
Screenshot_20201127-132840_Brave Screenshot_20201127-133651_Brave Screenshot_20201127-133734_Brave

Verification PASSED on Samsung Galaxy Tablet A running Android 10 using 1.17.74 CR: 87.0.4280.67

  • ensured that Ads received this month is being used/displayed on a clean install
  • ensured that Ads received this month is being used after upgrading from 1.17.72 CR: 87.0.4280.66
Clean Install 1.17.72 CR: 87.0.4280.66 Updating to 1.17.74 CR: 87.0.4280.67
Screenshot_20201127-142959_Brave Screenshot_20201127-141600_Brave Screenshot_20201127-141809_Brave

Verification PASSED on macOS x64 10.15.7 Catalina using

Brave | 1.17.75 Chromium: 87.0.4280.88 (Official Build) (x86_64)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | macOS Version 10.15.7 (Build 19H15)
  • ensured that Ads received this month is being used/displayed on a clean install
  • ensured that Ads received this month is being used after upgrading from 1.17.72 CR: 87.0.4280.66
Clean Install 1.17.73 CR: 87.0.4280.66 Updating to 1.17.75 CR: 87.0.4280.88
1 17 75-clean 1 17 73 1 17 75-upgrade

Verification passed on

Brave 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Ubuntu 18.04 LTS
  • ensured that Ads received this month is being used/displayed on a clean install
    image

  • ensured that Ads received this month is being used after upgrading from 1.17.72 CR: 87.0.4280.66
    image

Logged #13032 for missing translations


Verification passed on


Brave | 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | Windows 10 OS Version 2004 (Build 19041.630)

  • ensured that Ads received this month is being used/displayed on a clean install
    image

  • ensured that Ads received this month is being used after upgrading from 1.17.72 CR: 87.0.4280.66
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment