Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] App crashes when Tab Groups or Conditional Tab Strip are enabled #12809

Closed
samartnik opened this issue Nov 20, 2020 · 1 comment · Fixed by brave/brave-core#7209
Closed

Comments

@samartnik
Copy link
Contributor

samartnik commented Nov 20, 2020

Description

App crashes when Tab Groups or Conditional Tab Strip are enabled from brave://flags. Tab Groups don't work with bottom toolbar, so in this case we just need to disable it. Conditional Tab Strip uses different bottom control and thus bottom toolbar should also be disabled.

Steps to reproduce

  1. Enable Tab Groups or Conditional Tab Strip from brave://flags.
  2. Exit app.
  3. Start app, it will crash.

Actual result

App crashes.

Expected result

No crash and no bottom toolbar when Tab Groups or Conditional Tab Strip are enabled.

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet):
  • Android version: all

Brave version

1.19.x, 1.18.x, 1.17.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality labels Nov 20, 2020
@samartnik samartnik self-assigned this Nov 20, 2020
@samartnik samartnik changed the title [Android] App crashes when Tab Groups are enabled [Android] App crashes when Tab Groups or ConditionalTabStrip are enabled Nov 20, 2020
@samartnik samartnik changed the title [Android] App crashes when Tab Groups or ConditionalTabStrip are enabled [Android] App crashes when Tab Groups or Conditional Tab Strip are enabled Nov 20, 2020
@samartnik samartnik added this to the 1.19.x - Nightly milestone Nov 20, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.17.74 x64 build

  • Verified enabling Tab Groups or Conditional Tab Strip from brave://flags doesn't crash the browser when relaunched

Verification passed on Samsung Tab A with Android 10 running 1.17.74 x64 build

  • Verified enabling Tab Groups or Conditional Tab Strip from brave://flags doesn't crash the browser when relaunched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment