Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With BG images off, there are only 4 visible top sites instead of 8 #12837

Closed
newuser-web opened this issue Nov 22, 2020 · 9 comments · Fixed by brave/brave-core#7255
Closed
Assignees
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include

Comments

@newuser-web
Copy link

newuser-web commented Nov 22, 2020

Updated issue description (by @bsclifton)

Timeline

  • Sponsored images was introduced in February this year (code merged 4 Feb 2020 to old android-tabs repo). This reduced number of top sites shown by default to 4. User could turn off background images and see the full 8
  • Version 1.17 (made live on Google Play store 19 Nov 2020) made top sites into a widget style control (other options being NTP stats and Binance). Even with background images disabled, user can only see 4 (because of the widget style control limitation).

Original issue description

I was having 8 frequently viewed websites on the screen when background image was turned off. Now after 1.17.72 update it is restricted to 4.

Brave version 1.17.72

@newuser-web newuser-web added the OS/Android Fixes related to Android browser functionality label Nov 22, 2020
@bsclifton bsclifton changed the title Your latest Android update is horrible. With BG images off, there are only 4 visible top sites instead of 8 Nov 23, 2020
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 23, 2020
@bsclifton bsclifton added this to the 1.17.x - Release #3 milestone Nov 23, 2020
@aaronsantamaria
Copy link

@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.17.74 x64 build

  • Verified disabling bg images and widgets shows stats and 2 rows of toptiles

Verification passed on OnePlus 6T with Android 10 running 1.17.74 x64 build

  • Verified disabling bg images and widgets shows stats and 2 rows of toptiles

@newuser-web
Copy link
Author

I'm using version 1.17.74 but 8 top sites are not visible

@srirambv
Copy link
Contributor

srirambv commented Nov 30, 2020

@newuser-web works fine. Maybe just takes a bit of time to get the list populated.

How many do you see? Can you add a screenshot?

@newuser-web
Copy link
Author

Only 4
Screenshot_2020-11-30-14-31-52-381_com brave browser

@srirambv
Copy link
Contributor

@newuser-web You still have widgets enabled. You have to disable them to get 2 rows of tiles. Click on the 3 dot menu on widget and select remove widget make sure all of them are removed. Only then you will get full 8 tiles

@newuser-web
Copy link
Author

Thanks

@l3ender
Copy link

l3ender commented Dec 27, 2020

I was able to get the top 8 sites showing after disabling background images, but as a new user to the browser it was not very intuitive to figure it out. I'm liking the browser, and look forward to future enhancements to add/customize widgets to give more flexibility on the new tab screen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants