Ad grants do not transfer to Uphold

[LaurenWags]

Description

Ad grants are not transferring to Uphold KYC'd wallet

Steps to Reproduce

1. Clean profile 1.18.x
2. Restore a wallet with a waiting ad grant (can skip onboarding/not enable Ads/AC)
3. Claim ad grant
4. Connect KYC'd wallet
5. Watch logs

Actual result:

Claim appears successful in logs, but BAT never makes it to Uphold

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/............/claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJib2R5........
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/60478a78-95a0-4c33-b4c0-0efb60b234a5/claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"LPjVn/jOnvo.........
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: 

Additionally, if you wait a minute or two, the balance in the browser will decrease so your BAT is lost.

Expected result:

Uphold should have the ad grant BAT reflected in the Brave Browser card

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @marshall @brave/legacy_qa @rebron

[LaurenWags]

Server side change looks good on macOS.

Verified passed using

Brave | 1.18.69 Chromium: 87.0.4280.88 (Official Build) (x86_64)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description on staging env.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/............./claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJib2R5Ijp7ImRl..........
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/............./claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"LPjVn/jOnvoO3...
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: 

Verified Ad grant BAT moved to Uphold account:

---

Verification passed on

Brave | 1.18.69 Chromium: 87.0.4280.88 (Official Build) (64-bit)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Verified STR from description on staging env.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/.................../claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJib2R5
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/......................../claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"LPjVn
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

Verified Ad grant BAT moved to Uphold account: