Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] missing bubble in URL bar to enable javascript #12973

Closed
LaurenWags opened this issue Dec 1, 2020 · 5 comments
Closed

[Desktop] missing bubble in URL bar to enable javascript #12973

LaurenWags opened this issue Dec 1, 2020 · 5 comments

Comments

@LaurenWags
Copy link
Member

Description

If you have scripts blocked on a site in the URL bar there's usually a bubble displayed/accessible for you to re-enable scripts. This is missing in 1.19.x

Steps to Reproduce

  1. Clean install
  2. Navigate to blizzard.com
  3. Open shields and go to advanced view
  4. Toggle "Scripts blocked" to on

Actual result:

No bubble in the URL bar:
Screen Shot 2020-12-01 at 3 21 39 PM

Expected result:

Bubble in URL bar like in 1.18.x:
Screen Shot 2020-12-01 at 3 19 03 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.19.43 Chromium: 87.0.4280.67 (Official Build) nightly (x86_64)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.17.x no
  • Can you reproduce this issue with the beta channel? 1.18.x no
  • Can you reproduce this issue with the nightly channel? 1.19.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@bsclifton
Copy link
Member

I thought this was removed on purpose? cc: @diracdeltas

@LaurenWags
Copy link
Member Author

If so, please close. Thanks! 😄

@diracdeltas
Copy link
Member

@LaurenWags yep, we removed it on purpose.

@bsclifton
Copy link
Member

Here we go - removed with brave/brave-core#7148 😄

@LaurenWags
Copy link
Member Author

perfect, thanks @bsclifton @diracdeltas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants